linux-kernel - Re: [PATCH] Fix the __riscv_copy_vec_words

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45d7bf9c-58fe-4808-9454-ff1167ead9ab@ghiti.fr>
Date: Fri, 28 Feb 2025 09:34:49 +0100
From: Alexandre Ghiti <alex@...ti.fr>
To: Tingbo Liao <tingbo.liao@...rfivetech.com>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix the __riscv_copy_vec_words_unaligned implementation

Hi Tingbo,

On 27/02/2025 08:27, Tingbo Liao wrote:
> Correct the VEC_S macro definition to fix the implementation
> of vector words copy in the case of unalignment in RISC-V.
>
> Signed-off-by: Tingbo Liao <tingbo.liao@...rfivetech.com>
> ---
>   arch/riscv/kernel/vec-copy-unaligned.S | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/vec-copy-unaligned.S b/arch/riscv/kernel/vec-copy-unaligned.S
> index d16f19f1b3b6..7ce4de6f6e69 100644
> --- a/arch/riscv/kernel/vec-copy-unaligned.S
> +++ b/arch/riscv/kernel/vec-copy-unaligned.S
> @@ -11,7 +11,7 @@
>   
>   #define WORD_SEW CONCATENATE(e, WORD_EEW)
>   #define VEC_L CONCATENATE(vle, WORD_EEW).v
> -#define VEC_S CONCATENATE(vle, WORD_EEW).v
> +#define VEC_S CONCATENATE(vse, WORD_EEW).v
>   
>   /* void __riscv_copy_vec_words_unaligned(void *, const void *, size_t) */
>   /* Performs a memcpy without aligning buffers, using word loads and stores. */


That's a good catch, thanks.

However, your patch title should be prefixed with "riscv:" :

"[PATCH] riscv: Fix the __riscv_copy_vec_words_unaligned implementation"

And you miss the following Fixes tag:

Fixes: e7c9d66e313b ("RISC-V: Report vector unaligned access speed hwprobe")

And then you can add:

Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>

Can you respin a v2 with all those modifications please?

Thanks,

Alex