linux-kernel - Re: [PATCH] drm/vboxvideo: Remove unused hgsmi_cursor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f853d48f-f0aa-45af-89f3-4081a620f234@suse.de>
Date: Fri, 28 Feb 2025 09:47:45 +0100
From: Thomas Zimmermann <tzimmermann@...e.de>
To: "Dr. David Alan Gilbert" <linux@...blig.org>, airlied@...il.com,
 simona@...ll.ch
Cc: hdegoede@...hat.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/vboxvideo: Remove unused hgsmi_cursor_position

Hi

Am 27.02.25 um 22:34 schrieb Dr. David Alan Gilbert:
> * linux@...blig.org (linux@...blig.org) wrote:
>> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>>
>> hgsmi_cursor_position() has been unused since 2018's
>> commit 35f3288c453e ("staging: vboxvideo: Atomic phase 1: convert cursor to
>> universal plane")
>>
>> Remove it.
>>
>> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> Hi David, Simona,
>    Will this one be picked up by drm-next?  It got Hans's
> review back on 16 Dec.
> ( in 2513e942-6391-4a96-b487-1e4ba19b7aeb@...hat.com )

Merged into drm-misc-next now. Apologies for the delay.

Best regards
Thomas

>
>    Thanks,
>
> Dave
>
>> ---
>>   drivers/gpu/drm/vboxvideo/hgsmi_base.c      | 37 ---------------------
>>   drivers/gpu/drm/vboxvideo/vboxvideo_guest.h |  2 --
>>   2 files changed, 39 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/vboxvideo/hgsmi_base.c b/drivers/gpu/drm/vboxvideo/hgsmi_base.c
>> index 87dccaecc3e5..db994aeaa0f9 100644
>> --- a/drivers/gpu/drm/vboxvideo/hgsmi_base.c
>> +++ b/drivers/gpu/drm/vboxvideo/hgsmi_base.c
>> @@ -181,40 +181,3 @@ int hgsmi_update_pointer_shape(struct gen_pool *ctx, u32 flags,
>>   
>>   	return rc;
>>   }
>> -
>> -/**
>> - * hgsmi_cursor_position - Report the guest cursor position.  The host may
>> - *                         wish to use this information to re-position its
>> - *                         own cursor (though this is currently unlikely).
>> - *                         The current host cursor position is returned.
>> - * Return: 0 or negative errno value.
>> - * @ctx:              The context containing the heap used.
>> - * @report_position:  Are we reporting a position?
>> - * @x:                Guest cursor X position.
>> - * @y:                Guest cursor Y position.
>> - * @x_host:           Host cursor X position is stored here.  Optional.
>> - * @y_host:           Host cursor Y position is stored here.  Optional.
>> - */
>> -int hgsmi_cursor_position(struct gen_pool *ctx, bool report_position,
>> -			  u32 x, u32 y, u32 *x_host, u32 *y_host)
>> -{
>> -	struct vbva_cursor_position *p;
>> -
>> -	p = hgsmi_buffer_alloc(ctx, sizeof(*p), HGSMI_CH_VBVA,
>> -			       VBVA_CURSOR_POSITION);
>> -	if (!p)
>> -		return -ENOMEM;
>> -
>> -	p->report_position = report_position;
>> -	p->x = x;
>> -	p->y = y;
>> -
>> -	hgsmi_buffer_submit(ctx, p);
>> -
>> -	*x_host = p->x;
>> -	*y_host = p->y;
>> -
>> -	hgsmi_buffer_free(ctx, p);
>> -
>> -	return 0;
>> -}
>> diff --git a/drivers/gpu/drm/vboxvideo/vboxvideo_guest.h b/drivers/gpu/drm/vboxvideo/vboxvideo_guest.h
>> index 55fcee3a6470..643c4448bdcb 100644
>> --- a/drivers/gpu/drm/vboxvideo/vboxvideo_guest.h
>> +++ b/drivers/gpu/drm/vboxvideo/vboxvideo_guest.h
>> @@ -34,8 +34,6 @@ int hgsmi_query_conf(struct gen_pool *ctx, u32 index, u32 *value_ret);
>>   int hgsmi_update_pointer_shape(struct gen_pool *ctx, u32 flags,
>>   			       u32 hot_x, u32 hot_y, u32 width, u32 height,
>>   			       u8 *pixels, u32 len);
>> -int hgsmi_cursor_position(struct gen_pool *ctx, bool report_position,
>> -			  u32 x, u32 y, u32 *x_host, u32 *y_host);
>>   
>>   bool vbva_enable(struct vbva_buf_ctx *vbva_ctx, struct gen_pool *ctx,
>>   		 struct vbva_buffer *vbva, s32 screen);
>> -- 
>> 2.47.1
>>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)