[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <33e64b12-aa07-4e78-933a-b07c37ff1d84@lucifer.local>
Date: Fri, 28 Feb 2025 09:49:02 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: "Liam R. Howlett" <Liam.Howlett@...cle.com>,
Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
Miguel Ojeda <ojeda@...nel.org>, Matthew Wilcox <willy@...radead.org>,
Vlastimil Babka <vbabka@...e.cz>, John Hubbard <jhubbard@...dia.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Arnd Bergmann <arnd@...db.de>, Jann Horn <jannh@...gle.com>,
Suren Baghdasaryan <surenb@...gle.com>,
Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>,
Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>,
Andreas Hindborg <a.hindborg@...nel.org>,
Trevor Gross <tmgross@...ch.edu>, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, rust-for-linux@...r.kernel.org,
Balbir Singh <balbirs@...dia.com>,
Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v14 0/8] Rust support for mm_struct, vm_area_struct, and
mmap
+cc Linus
OK since Andrew seems caught up with other things, let's go ahead and propose
the entire thing to make life easy.
Could you send a v15 with any fixes (don't think any are necessary now?) and
add a patch to add this to MAINTAINERS in the alphabetical location:
MEMORY MANAGEMENT [RUST]
M: Alice Ryhl <aliceryhl@...gle.com>
R: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
R: Liam R. Howlett <Liam.Howlett@...cle.com>
L: linux-mm@...ck.org
L: rust-for-linux@...r.kernel.org
S: Maintained
W: http://www.linux-mm.org
T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
S: Maintained
F: rust/helpers/mm.c
F: rust/kernel/mm.rs
F: rust/kernel/mm/
With every patch reviewed from both mm and rust side, from my point of view
there is to me absolutely _no reason_ this should not be taken, though of
course ultimately it's up to Andrew/Linus.
At any rate, hopefully this can help get us moving again here :)
Very keen to get this landed!
Cheers, Lorenzo
On Fri, Feb 14, 2025 at 12:20:18PM +0000, Lorenzo Stoakes wrote:
> On Fri, Feb 14, 2025 at 12:56:29PM +0100, Alice Ryhl wrote:
> > On Thu, Feb 13, 2025 at 8:46 PM Liam R. Howlett <Liam.Howlett@...cle.com> wrote:
> > >
> > > * Lorenzo Stoakes <lorenzo.stoakes@...cle.com> [250213 07:16]:
> > > > On Thu, Feb 13, 2025 at 01:03:04PM +0100, Miguel Ojeda wrote:
> > > > > On Thu, Feb 13, 2025 at 12:50 PM Lorenzo Stoakes
> > > > > <lorenzo.stoakes@...cle.com> wrote:
> > > > > >
> > > > > > Right, I don't mean the rust subsystem, I mean designated rust
> > > > > > maintainers. The point being that this won't add workload to Andrew, nor
> > > > > > require him nor other mm C people to understand rust.
> > > > >
> > > > > Sounds good, and apologies for being pedantic, but given the recent
> > > > > discussions, I thought I should clarify just in case others read it
> > > > > differently.
> > > > >
> > > > > In the same vein, one more quick thing (that you probably didn't mean
> > > > > in this way, but still, I think it is better I add the note, sorry): I
> > > > > don't think it is true that it will not add workload to Andrew or MM
> > > > > in general. It always adds some workload, even if the maintainers
> > > > > don't handle the patches at all, since they may still need to perform
> > > > > a small change in something Rust related due to another change they
> > > > > need to do, or perhaps at least contact the Rust sub-maintainer to do
> > > > > it for them, etc.
> > > > >
> > > > > https://rust-for-linux.com/rust-kernel-policy#didnt-you-promise-rust-wouldnt-be-extra-work-for-maintainers
> > > > >
> > > > > Cheers,
> > > > > Miguel
> > > >
> > > > Ack, for the record I'm happy to help with any work that might come up.
> > >
> > > Ack, here too.
> > >
> > > Without the drama, I'm not sure how we'd feel so alive :P
> > >
> > > Can I be added to whatever list so I can be Cc'ed on the changes on your
> > > side?
> >
> > I'm happy to format the entries whichever way you all prefer, but for
> > example it could be a new MAINTAINERS entry below MEMORY MAPPING along
> > these lines:
> >
> > MEMORY MANAGEMENT/MAPPING [RUST]
>
> I think a general:
>
> MEMORY MANAGEMENT [RUST]
>
> works better here as it ought to (at least for the time being) cover off all
> rust mm stuff.
>
> > M: Alice Ryhl <aliceryhl@...gle.com>
>
> I wonder if we should have Andrew as a co-maintainer here so people also
> send to Andrew also for merge? (and obviously as the mm maintainer he may
> have commentary).
>
> > R: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
>
> Am happy to be a reviewer this is fine!
>
> > R: Liam R. Howlett <Liam.Howlett@...cle.com>
>
> I am sure Liam is also, but of course he can comment himself :)
>
> > L: linux-mm@...ck.org
> > L: rust-for-linux@...r.kernel.org
> > S: Maintained
>
> Probably need these here too if Andrew is taking in his tree:
>
> W: http://www.linux-mm.org
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>
> > F: rust/helpers/mm.c
> > F: rust/kernel/mm.rs
> > F: rust/kernel/mm/
> >
> > Alice
>
> But in general with tweaks I am happy for this to be added to MAINTAINERS
> _personally_, am I but a minor figure however, it is up to Andrew
> ultimately :)
Powered by blists - more mailing lists