[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250228105247-GYB52883@gentoo>
Date: Fri, 28 Feb 2025 10:52:47 +0000
From: Yixun Lan <dlan@...too.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Alex Elder <elder@...cstar.com>, Bartosz Golaszewski <brgl@...ev.pl>,
Thomas Gleixner <tglx@...utronix.de>,
Inochi Amaoto <inochiama@...il.com>, linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-riscv@...ts.infradead.org,
spacemit@...ts.linux.dev
Subject: Re: [PATCH 1/2] irqdomain: support three-cell scheme interrupts
Hi Linus Walleij:
On 09:44 Fri 28 Feb , Linus Walleij wrote:
> On Thu, Feb 27, 2025 at 9:42 PM Yixun Lan <dlan@...too.org> wrote:
>
> > > This function is meant for "twocell". There is also another function
> > > irq_domain_translate_onecell(). Why don't you just create
> > > irq_domain_translate_threecell" instead?
> > >
> > good question!
> >
> > it's too many changes for adding "threecell" which I thought not worth
> > the effort, or maybe we can rename the function to *twothreecell()?
> >
> > I'm not sure which way to go is the best, ideas from maintainer are
> > welcome
>
> Yeah just rename it twothreecell, that's fine, we will understand it :)
>
there will be quite a lot files to touch, which looks a little bit scary
but anyway, I'm fine with either way..
$ git grep irq_domain_translate_twocell | cut -f 1 -d ':' | sort -u | wc -l
11
Thomas Gleixner, do you agree with this direction? then I can work on it
--
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55
Powered by blists - more mailing lists