linux-kernel - Re: [PATCH v2 2/2] x86/mm: Remove unnecessary include in set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ce29384e-b3fe-4196-a986-bb57a5d693d6@arm.com>
Date: Fri, 28 Feb 2025 11:56:17 +0100
From: Kevin Brodsky <kevin.brodsky@....com>
To: Ingo Molnar <mingo@...nel.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, bp@...en8.de,
 dan.j.williams@...el.com, dave.hansen@...ux.intel.com, david@...hat.com,
 jane.chu@...cle.com, osalvador@...e.de, tglx@...utronix.de
Subject: Re: [PATCH v2 2/2] x86/mm: Remove unnecessary include in set_memory.h

On 27/02/2025 14:03, Ingo Molnar wrote:
> * Ingo Molnar <mingo@...nel.org> wrote:
>
>> So I tried to pick up this patch belatedly, but there's more places 
>> that mistakenly learned to rely on the stray <linux/mm.h> inclusion, 
>> for example on x86 defconfig-ish kernels:
>>
>>
>>   In file included from drivers/gpu/drm/i915/gt/intel_ggtt.c:6:
>>   ./arch/x86/include/asm/set_memory.h:40:57: error: unknown type name ‘pgprot_t’
>>   40 | int __set_memory_prot(unsigned long addr, int numpages, pgprot_t prot);
>>   |                                                         ^~~~~~~~

This patch relies on patch 1 in this series, which removes
__set_memory_prot(). I seem to be able to build x86_64_defconfig without
issue with both patches applies on the latest mainline.

> BTW., I did a few touchups to the changelog (see below) - mind picking 
> that up once you submit -v2?

Very happy with the touchups, thanks for having a look! Given my comment
above, I don't believe there is a need to post a v3 - feel free to amend
the commit message when applying the patches.

- Kevin