linux-kernel - Re: [PATCH] gpio: Document the 'valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f9fdc656-27c8-4243-9a54-3add4d4722c8@gmail.com>
Date: Fri, 28 Feb 2025 13:02:10 +0200
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Biju Das <biju.das.jz@...renesas.com>,
 Geert Uytterhoeven <geert@...ux-m68k.org>,
 Linus Walleij <linus.walleij@...aro.org>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
 Bartosz Golaszewski <brgl@...ev.pl>,
 "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: Document the 'valid_mask' being internal

Hi dee Ho peeps (Biju, Geert, Linus and all)

On 28/02/2025 12:28, Biju Das wrote:
> Hi Geert,
> 
>> -----Original Message-----
>> From: Geert Uytterhoeven <geert@...ux-m68k.org>
>> On Fri, 28 Feb 2025 at 09:07, Linus Walleij <linus.walleij@...aro.org> wrote:
>>> On Wed, Feb 26, 2025 at 12:42 PM Matti Vaittinen
>>> <mazziesaccount@...il.com> wrote:
>>>> On 26/02/2025 12:18, Linus Walleij wrote:

> I agree, when the code is mainlined at that time set_multiple() has some draw backs and hence
> the check is added to take care of GPIO holes.

If I don't read it wrong, rcar GPIO supports some input enabling "en 
masse" during the probe. It seems to me the gpio_rcar_enable_inputs() 
does also need the valid GPIOs information - I suppose some of the GPIOs 
may have been masked in the device-tree, and those shouldn't be enabled.

It feels counter productive to hide the valid_mask - and do some 
device-tree parsing in the driver(s) which may need it.

I suppose we can still hide the valid_mask in struct gpio_device as 
suggested - but then we should probably create a getter for it in the 
gpiolib.

Or does someone see a way around needing the valid_mask in the 
gpio_rcar_enable_inputs() ?

Have a nice weekend!

Yours,
	-- Matti