linux-kernel - Re: [PATCH] riscv: mm: Don't use %pK through printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <99529247-b489-4e10-afc8-3abe6fbd777e@ghiti.fr>
Date: Fri, 28 Feb 2025 13:38:08 +0100
From: Alexandre Ghiti <alex@...ti.fr>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: mm: Don't use %pK through printk

Hi Thomas,

On 17/02/2025 08:37, Thomas Weißschuh wrote:
> Restricted pointers ("%pK") are not meant to be used through printk().
> It can unintentionally expose security sensitive, raw pointer values.
>
> Use regular pointer formatting instead.
>
> Link: https://lore.kernel.org/lkml/20250113171731-dc10e3c1-da64-4af0-b767-7c7070468023@linutronix.de/
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> ---
>   arch/riscv/mm/physaddr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/mm/physaddr.c b/arch/riscv/mm/physaddr.c
> index 18706f457da7ecf84591510ea26789f7ae3e9abf..559d291fac5c62271a0e793321c97b87bf4e1b3c 100644
> --- a/arch/riscv/mm/physaddr.c
> +++ b/arch/riscv/mm/physaddr.c
> @@ -12,7 +12,7 @@ phys_addr_t __virt_to_phys(unsigned long x)
>   	 * Boundary checking aginst the kernel linear mapping space.
>   	 */
>   	WARN(!is_linear_mapping(x) && !is_kernel_mapping(x),
> -	     "virt_to_phys used for non-linear address: %pK (%pS)\n",
> +	     "virt_to_phys used for non-linear address: %p (%pS)\n",
>   	     (void *)x, (void *)x);
>   
>   	return __va_to_pa_nodebug(x);
>
> ---
> base-commit: 0ad2507d5d93f39619fc42372c347d6006b64319
> change-id: 20250217-restricted-pointers-riscv-62ca6d5fbf14
>
> Best regards,


Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>

Thanks,

Alex