linux-kernel - Re: [PATCH 1/9] drivers/perf: hisi: Extend struct hisi_pmu_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250301062343.GA27700@willie-the-truck>
Date: Sat, 1 Mar 2025 06:23:44 +0000
From: Will Deacon <will@...nel.org>
To: Yicong Yang <yangyicong@...wei.com>
Cc: mark.rutland@....com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, jonathan.cameron@...wei.com,
	prime.zeng@...ilicon.com, linuxarm@...wei.com,
	yangyicong@...ilicon.com, wangyushan12@...wei.com
Subject: Re: [PATCH 1/9] drivers/perf: hisi: Extend struct hisi_pmu_dev_info

On Tue, Feb 18, 2025 at 05:19:52PM +0800, Yicong Yang wrote:
> From: Junhao He <hejunhao3@...wei.com>
> 
> The counter bits and event range may differ from versions of a
> certain uncore PMU. Make this device specific information into
> struct hisi_pmu_dev_info. This will help to simplify the
> initialization process by using a list of struct hisi_pmu_dev_info
> rather than checking the version.
> 
> Signed-off-by: Junhao He <hejunhao3@...wei.com>
> Signed-off-by: Yicong Yang <yangyicong@...ilicon.com>
> ---
>  drivers/perf/hisilicon/hisi_uncore_pmu.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.h b/drivers/perf/hisilicon/hisi_uncore_pmu.h
> index f4fed2544877..777675838b80 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_pmu.h
> +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.h
> @@ -72,6 +72,8 @@ struct hisi_uncore_ops {
>  struct hisi_pmu_dev_info {
>  	const char *name;
>  	const struct attribute_group **attr_groups;
> +	u32 counter_bits;
> +	u32 check_event;
>  	void *private;
>  };

This doesn't really do anything on its own; please just fold it into the
patch where the new fields are used.

Will