linux-kernel - Re: [PATCH v2] perf tools: Skip BPF sideband event for userspace profiling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPhsuW5JFP-QuE_HZBJm+RT+ytsV72ihP0g_CvByKB_S+fHV_g@mail.gmail.com>
Date: Fri, 28 Feb 2025 16:25:03 -0800
From: Song Liu <song@...nel.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>, Ian Rogers <irogers@...gle.com>, 
	Kan Liang <kan.liang@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, Peter Zijlstra <peterz@...radead.org>, 
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>, 
	linux-perf-users@...r.kernel.org, James Clark <james.clark@...aro.org>
Subject: Re: [PATCH v2] perf tools: Skip BPF sideband event for userspace profiling

On Fri, Feb 28, 2025 at 4:20 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> On Thu, Feb 27, 2025 at 10:50:26AM -0800, Song Liu wrote:
> > On Wed, Feb 26, 2025 at 9:17 PM Namhyung Kim <namhyung@...nel.org> wrote:
> > >
> > > The BPF sideband information is tracked using a separate thread and
> > > evlist.  But it's only useful for profiling kernel and we can skip it
> > > when users profile their application only in userspace.
> > >
> > > It seems it already fails to open the sideband event in that case.
> > > Let's remove the noise in the verbose output anyway.
> > >
> > > Cc: Song Liu <song@...nel.org>
> > > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> >
> > This turns out to be more complicated than I thought. I actually
> > like v1 better.
>
> Sure, the complexity comes from moving the code to reduce the
> duplication.  But either is fine to me.
>
> Can I add your Acked-by to v1, then?

Yes, you can add to v1:

Acked-by: Song Liu <song@...nel.org>

Thanks,
Song