linux-kernel - Re: [PATCH 1/2] drivers/base: fix checkpatch.pl warnings in attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025022827-gesture-matted-d400@gregkh>
Date: Fri, 28 Feb 2025 23:31:46 -0800
From: Greg KH <gregkh@...uxfoundation.org>
To: Ayaan Mirza Baig <ayaanmirzabaig85@...il.com>
Cc: ayaanmirza85@...il.com, dakr@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] drivers/base: fix checkpatch.pl warnings in
 attribute_container.c (v2)

On Thu, Feb 27, 2025 at 06:11:28PM +0530, Ayaan Mirza Baig wrote:
> This patch applies only cosmetic changes such as
> whitespace fixes, formatting and typos. These
> changes are flagged by checkpatch.pl
> 
> Signed-off-by: Ayaan Mirza Baig <ayaanmirzabaig85@...il.com>
> ---
>  drivers/base/attribute_container.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/base/attribute_container.c b/drivers/base/attribute_container.c
> index b6f941a6ab69..69637b2ec3bc 100644
> --- a/drivers/base/attribute_container.c
> +++ b/drivers/base/attribute_container.c
> @@ -5,7 +5,7 @@
>   * Copyright (c) 2005 - James Bottomley <James.Bottomley@...eleye.com>
>   *
>   * The basic idea here is to enable a device to be attached to an
> - * aritrary numer of classes without having to allocate storage for them.
> + * aritrary number of classes without having to allocate storage for them.
>   * Instead, the contained classes select the devices they need to attach
>   * to via a matching function.
>   */
> @@ -21,7 +21,8 @@
>  #include "base.h"
>  
>  /* This is a private structure used to tie the classdev and the
> - * container .. it should never be visible outside this file */
> + * container .. it should never be visible outside this file
> + */
>  struct internal_container {
>  	struct klist_node node;
>  	struct attribute_container *cont;
> @@ -449,7 +450,7 @@ attribute_container_remove_attrs(struct device *classdev)
>  
>  	if (cont->grp) {
>  		sysfs_remove_group(&classdev->kobj, cont->grp);
> -		return ;
> +		return;
>  	}
>  
>  	for (i = 0; attrs[i]; i++)
> -- 
> 2.47.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot