linux-kernel - [PATCH] xfs: Simplify maximum determination in xrep_calc_ag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2b6b0608-136b-4328-a42f-eb5ca77688a0@web.de>
Date: Sat, 1 Mar 2025 11:30:52 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: linux-xfs@...r.kernel.org, Carlos Maiolino <cem@...nel.org>,
 Chandan Babu R <chandanbabu@...nel.org>, "Darrick J. Wong"
 <djwong@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
 Qasim Ijaz <qasdev00@...il.com>, Natalie Vock <natalie.vock@....de>
Subject: [PATCH] xfs: Simplify maximum determination in xrep_calc_ag_resblks()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sat, 1 Mar 2025 11:24:52 +0100

Reduce nested max() calls by a single max3() call in this
function implementation.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 fs/xfs/scrub/repair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/scrub/repair.c b/fs/xfs/scrub/repair.c
index 3b5288d3ef4e..6b23a3943907 100644
--- a/fs/xfs/scrub/repair.c
+++ b/fs/xfs/scrub/repair.c
@@ -382,7 +382,7 @@ xrep_calc_ag_resblks(
 			refcbt_sz);
 	xfs_perag_put(pag);

-	return max(max(bnobt_sz, inobt_sz), max(rmapbt_sz, refcbt_sz));
+	return max3(bnobt_sz, inobt_sz, max(rmapbt_sz, refcbt_sz));
 }

 #ifdef CONFIG_XFS_RT
--
2.48.1