linux-kernel - Re: [PATCH v15 00/15] PCI: EP: Add RC-to-EP doorbell with platform MSI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86ldtpot6m.wl-maz@kernel.org>
Date: Sat, 01 Mar 2025 12:02:09 +0000
From: Marc Zyngier <maz@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: Kishon Vijay Abraham I <kishon@...nel.org>,	"Rafael J. Wysocki"
 <rafael@...nel.org>,	Thomas Gleixner <tglx@...utronix.de>,	Anup Patel
 <apatel@...tanamicro.com>,	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Danilo Krummrich <dakr@...nel.org>,	Manivannan Sadhasivam
 <manivannan.sadhasivam@...aro.org>,	Krzysztof Wilczyński
 <kw@...ux.com>,	Bjorn Helgaas <bhelgaas@...gle.com>,	Arnd Bergmann
 <arnd@...db.de>,	Shuah Khan <shuah@...nel.org>,	Richard Zhu
 <hongxing.zhu@....com>,	Lucas Stach <l.stach@...gutronix.de>,	Lorenzo
 Pieralisi <lpieralisi@...nel.org>,	Rob Herring <robh@...nel.org>,	Shawn Guo
 <shawnguo@...nel.org>,	Sascha Hauer <s.hauer@...gutronix.de>,	Pengutronix
 Kernel Team <kernel@...gutronix.de>,	Fabio Estevam <festevam@...il.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,	Conor Dooley
 <conor+dt@...nel.org>,	Niklas Cassel <cassel@...nel.org>,
	dlemoal@...nel.org,	jdmason@...zu.us,	linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,	linux-pci@...r.kernel.org,
	linux-kselftest@...r.kernel.org,	imx@...ts.linux.dev,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v15 00/15] PCI: EP: Add RC-to-EP doorbell with platform MSI controller

On Thu, 20 Feb 2025 20:01:10 +0000,
Frank Li <Frank.li@....com> wrote:
> 
> On Tue, Feb 11, 2025 at 02:21:53PM -0500, Frank Li wrote:
> 
> Thomas Gleixner and Marc Zyngier:
> 
> 	Do you have any comments about irq/msi part?

It certainly looks better and less invasive than the previous
incarnations. Things to fix:

- Documentation: the msi-map property usage is undefined outside of a
  PCIe RC, and the way you describe its use is so vague I read
  anything in it. Please update
  Documentation/devicetree/bindings/pci/pci-msi.txt to reflect the new
  use case.

- This IMMUTABLE thing serves no purpose, because you don't randomly
  plug this end-point block on any MSI controller. They come as part
  of an SoC.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.