linux-kernel - Re: [PATCH] genirq/msi: Add the address and data that show MSI/MSIX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f4b46a9-e71f-4201-a55f-41cc26d3ba66@163.com>
Date: Sat, 1 Mar 2025 20:33:01 +0800
From: Hans Zhang <18255117159@....com>
To: Thomas Gleixner <tglx@...utronix.de>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: kw@...ux.com, kwilczynski@...nel.org, bhelgaas@...gle.com,
 cassel@...nel.org, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] genirq/msi: Add the address and data that show MSI/MSIX



On 2025/3/1 02:14, Thomas Gleixner wrote:
> On Fri, Feb 28 2025 at 23:17, Hans Zhang wrote:
>> I'm very sorry that I didn't understand what you meant at the
>> beginning.
> 
> No problem.
> 
>>
>> +static void msi_domain_debug_show(struct seq_file *m, struct irq_domain *d,
>> +                                 struct irq_data *irqd, int ind)
>> +{
>> +       struct msi_desc *desc;
>> +       bool is_msix;
>> +
>> +       desc = irq_get_msi_desc(irqd->irq);
>> +       if (!desc)
>> +               return;
>> +
>> +       is_msix = desc->pci.msi_attrib.is_msix;
>> +       seq_printf(m, "%*s%s:", ind, "", is_msix ? "msix" : "msi");
>> +       seq_printf(m, "\n%*saddress_hi: 0x%08x", ind + 1, "",
>> +                  desc->msg.address_hi);
> 
> No need for these line breaks. You have 100 characters available.
> 

Will change.

Best regards
Hans

>> +       seq_printf(m, "\n%*saddress_lo: 0x%08x", ind + 1, "",
>> +                  desc->msg.address_lo);
>> +       seq_printf(m, "\n%*smsg_data:   0x%08x\n", ind + 1, "",
>> +                  desc->msg.data);
>> +}
>> +
>>    static const struct irq_domain_ops msi_domain_ops = {
>>           .alloc          = msi_domain_alloc,
>>           .free           = msi_domain_free,
>>           .activate       = msi_domain_activate,
>>           .deactivate     = msi_domain_deactivate,
>>           .translate      = msi_domain_translate,
>> +       .debug_show     = msi_domain_debug_show,
>>    };
> 
> Looks about right.
> 
> Thanks,
> 
>          tglx