linux-kernel - Re: [GIT PULL] afs, rxrpc: Clean up refcounting on afs_cell and afs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3475525.1740835404@warthog.procyon.org.uk>
Date: Sat, 01 Mar 2025 13:23:24 +0000
From: David Howells <dhowells@...hat.com>
Cc: dhowells@...hat.com, Jakub Kicinski <kuba@...nel.org>,
    Christian Brauner <brauner@...nel.org>,
    Marc Dionne <marc.dionne@...istor.com>,
    "David S. Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
    linux-afs@...ts.infradead.org, linux-fsdevel@...ts.infradead.org,
    netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] afs, rxrpc: Clean up refcounting on afs_cell and afs_server records

David Howells <dhowells@...hat.com> wrote:

>         cell->dynroot_ino = idr_alloc_cyclic(&net->cells_dyn_ino, cell,
>                                              2, INT_MAX / 2, GFP_KERNEL);
> -       if (cell->dynroot_ino < 0)
> +       if ((int)cell->dynroot_ino < 0)
>                 goto error;

That's not right.  I need to copy the error into 'ret' before jumping to
error.  Probably better to do:

	ret = idr_alloc_cyclic(&net->cells_dyn_ino, cell,
                               2, INT_MAX / 2, GFP_KERNEL);
	if (ret < 0)
		goto error;
	cell->dynroot_ino = ret;

David