linux-kernel - Re: [PATCH v2 0/4] tools/nolibc: MIPS: entrypoint cleanups and N32/N64 ABIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2503011543100.12637@angie.orcam.me.uk>
Date: Sat, 1 Mar 2025 15:47:52 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Willy Tarreau <w@....eu>
cc: Thomas Weißschuh <linux@...ssschuh.net>, 
    Shuah Khan <shuah@...nel.org>, 
    Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
    linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, 
    linux-mips@...r.kernel.org
Subject: Re: [PATCH v2 0/4] tools/nolibc: MIPS: entrypoint cleanups and
 N32/N64 ABIs

On Sat, 1 Mar 2025, Willy Tarreau wrote:

> > Introduce support for the N32 and N64 ABIs. As preparation, the
> > entrypoint is first simplified significantly. Thanks to Maciej for all
> > the valuable information.
> > 
> > Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> > ---
> > Changes in v2:
> > - Clean up entrypoint first
> > - Annotate #endifs
> > - Link to v1: https://lore.kernel.org/r/20250212-nolibc-mips-n32-v1-1-6892e58d1321@weissschuh.net
> 
> OK I tested this series on my glinet (MIPS 24Kc, XARCH=mips32be) and
> it worked fine, confirming that the stack alignments were not needed
> and that the cleanup is quite welcome!

 I do hope it can wait two weeks until I'm back from my holiday.  I mean 
to double-check the code visually and verify it with my R3000 and R4000 
hardware (the latter for n64/n32 too), both of which are less forgiving 
when it comes to instruction scheduling (I can check with a 74Kf too).

  Maciej