linux-kernel - Re: [PATCH] mailbox: tegra-hsp: Add check for devm_kstrdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABb+yY3wC5Rp4DJFL=61uyYyGtJ-kPTWks8JMG7jQpp=V3P-Zg@mail.gmail.com>
Date: Sat, 1 Mar 2025 10:29:29 -0600
From: Jassi Brar <jassisinghbrar@...il.com>
To: Haoxiang Li <haoxiang_li2024@....com>
Cc: thierry.reding@...il.com, jonathanh@...dia.com, brgl@...ev.pl, 
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH] mailbox: tegra-hsp: Add check for devm_kstrdup_const()

On Tue, Feb 18, 2025 at 8:28 PM Haoxiang Li <haoxiang_li2024@....com> wrote:
>
> Add check for the return value of devm_kstrdup_const() in
> tegra_hsp_doorbell_create() to catch potential exception.
>
> Fixes: a54d03ed01b4 ("mailbox: tegra-hsp: use devm_kstrdup_const()")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@....com>
> ---
>  drivers/mailbox/tegra-hsp.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c
> index c1981f091bd1..773a1cf6d93d 100644
> --- a/drivers/mailbox/tegra-hsp.c
> +++ b/drivers/mailbox/tegra-hsp.c
> @@ -285,6 +285,8 @@ tegra_hsp_doorbell_create(struct tegra_hsp *hsp, const char *name,
>         db->channel.hsp = hsp;
>
>         db->name = devm_kstrdup_const(hsp->dev, name, GFP_KERNEL);
> +       if (!db->name)
> +               return ERR_PTR(-ENOMEM);

 tegra_hsp_doorbell.name seems unused, so maybe just get rid of it...  Thierry ?

Thnx