linux-kernel - Re: [PATCH v2 24/45] mailbox: Switch to use hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABb+yY3tGBg=t1FV2diZKPa+dt3_9LZ6gqHFDJhMrhoRo2MzRw@mail.gmail.com>
Date: Sat, 1 Mar 2025 10:43:21 -0600
From: Jassi Brar <jassisinghbrar@...il.com>
To: Nam Cao <namcao@...utronix.de>
Cc: Anna-Maria Behnsen <anna-maria@...utronix.de>, Frederic Weisbecker <frederic@...nel.org>, 
	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org, 
	Zack Rusin <zack.rusin@...adcom.com>
Subject: Re: [PATCH v2 24/45] mailbox: Switch to use hrtimer_setup()

On Wed, Feb 5, 2025 at 4:47 AM Nam Cao <namcao@...utronix.de> wrote:
>
> hrtimer_setup() takes the callback function pointer as argument and
> initializes the timer completely.
>
> Replace hrtimer_init() and the open coded initialization of
> hrtimer::function with the new setup mechanism.
>
> Patch was created by using Coccinelle.
>
> Acked-by: Zack Rusin <zack.rusin@...adcom.com>
> Signed-off-by: Nam Cao <namcao@...utronix.de>
> Cc: Jassi Brar <jassisinghbrar@...il.com>
> ---
>  drivers/mailbox/mailbox.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c
> index d3d26a2c9895..118beaf447aa 100644
> --- a/drivers/mailbox/mailbox.c
> +++ b/drivers/mailbox/mailbox.c
> @@ -534,9 +534,7 @@ int mbox_controller_register(struct mbox_controller *mbox)
>                         return -EINVAL;
>                 }
>
> -               hrtimer_init(&mbox->poll_hrt, CLOCK_MONOTONIC,
> -                            HRTIMER_MODE_REL);
> -               mbox->poll_hrt.function = txdone_hrtimer;
> +               hrtimer_setup(&mbox->poll_hrt, txdone_hrtimer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
>                 spin_lock_init(&mbox->poll_hrt_lock);
>         }
>
Applied. Thanks.