linux-kernel - Re: [PATCH 10/18] rtc: pl030: drop needless struct pl030

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdamF4B1y+zr-Y_XB8gAoSv2Q2U4VxuZd+ivZq7KV1Quyw@mail.gmail.com>
Date: Sat, 1 Mar 2025 19:11:56 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: André Draszik <andre.draszik@...aro.org>
Cc: Chanwoo Choi <cw00.choi@...sung.com>, Krzysztof Kozlowski <krzk@...nel.org>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Joel Stanley <joel@....id.au>, 
	Andrew Jeffery <andrew@...econstruct.com.au>, Hans Ulli Kroll <ulli.kroll@...glemail.com>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Kevin Hilman <khilman@...libre.com>, 
	Jerome Brunet <jbrunet@...libre.com>, 
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Tóth János <gomba007@...il.com>, 
	Dianlong Li <long17.cool@....com>, linux-kernel@...r.kernel.org, 
	linux-rtc@...r.kernel.org, linux-samsung-soc@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, 
	linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH 10/18] rtc: pl030: drop needless struct pl030_rtc::rtc member

On Fri, Feb 28, 2025 at 3:07 PM André Draszik <andre.draszik@...aro.org> wrote:

> The memory pointed to by the ::rtc member is managed via devres, and
> no code in this driver uses it past _probe().
>
> We can drop it from the structure and just use a local temporary
> variable, reducing runtime memory consumption by a few bytes.
>
> Signed-off-by: André Draszik <andre.draszik@...aro.org>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij