linux-kernel - Re: [PATCH] io_uring/rsrc: use rq_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6272ce74-cd1e-4386-ac84-2ca7df5dab33@gmail.com>
Date: Sat, 1 Mar 2025 01:24:36 +0000
From: Pavel Begunkov <asml.silence@...il.com>
To: Caleb Sander Mateos <csander@...estorage.com>,
 Jens Axboe <axboe@...nel.dk>
Cc: io-uring@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] io_uring/rsrc: use rq_data_dir() to compute bvec dir

On 2/28/25 22:30, Caleb Sander Mateos wrote:
> The macro rq_data_dir() already computes a request's data direction.
> Use it in place of the if-else to set imu->dir.
> 
> Signed-off-by: Caleb Sander Mateos <csander@...estorage.com>
> ---
>   io_uring/rsrc.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
> index 45bfb37bca1e..3107a03d56b8 100644
> --- a/io_uring/rsrc.c
> +++ b/io_uring/rsrc.c
> @@ -957,15 +957,11 @@ int io_buffer_register_bvec(struct io_uring_cmd *cmd, struct request *rq,
>   	imu->nr_bvecs = nr_bvecs;
>   	refcount_set(&imu->refs, 1);
>   	imu->release = release;
>   	imu->priv = rq;
>   	imu->is_kbuf = true;
> -
> -	if (op_is_write(req_op(rq)))
> -		imu->dir = IO_IMU_SOURCE;
> -	else
> -		imu->dir = IO_IMU_DEST;
> +	imu->dir = 1 << rq_data_dir(rq);

rq_data_dir returns READ/WRITE, which should be fine, but it'd
be nicer to be more explicit unless it's already enforced
somewhere else

BUILD_BUG_ON(WRITE ==  ITER_SOURCE);
ditto for READ


>   
>   	bvec = imu->bvec;
>   	rq_for_each_bvec(bv, rq, rq_iter)
>   		*bvec++ = bv;
>   

-- 
Pavel Begunkov