linux-kernel - Re: [PATCH v8 9/9] misc: add FPC202 dual port controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202503020450.UW2PuA6X-lkp@intel.com>
Date: Sun, 2 Mar 2025 04:31:48 +0800
From: kernel test robot <lkp@...el.com>
To: Romain Gantois <romain.gantois@...tlin.com>,
	Wolfram Sang <wsa-dev@...g-engineering.com>,
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Derek Kiernan <derek.kiernan@....com>,
	Dragan Cvetic <dragan.cvetic@....com>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>
Cc: oe-kbuild-all@...ts.linux.dev, linux-media@...r.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Kory Maincent <kory.maincent@...tlin.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
	Romain Gantois <romain.gantois@...tlin.com>
Subject: Re: [PATCH v8 9/9] misc: add FPC202 dual port controller driver

Hi Romain,

kernel test robot noticed the following build errors:

[auto build test ERROR on 2014c95afecee3e76ca4a56956a936e23283f05b]

url:    https://github.com/intel-lab-lkp/linux/commits/Romain-Gantois/dt-bindings-misc-Describe-TI-FPC202-dual-port-controller/20250227-182532
base:   2014c95afecee3e76ca4a56956a936e23283f05b
patch link:    https://lore.kernel.org/r/20250227-fpc202-v8-9-b7994117fbe2%40bootlin.com
patch subject: [PATCH v8 9/9] misc: add FPC202 dual port controller driver
config: sparc-randconfig-r051-20250302 (https://download.01.org/0day-ci/archive/20250302/202503020450.UW2PuA6X-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250302/202503020450.UW2PuA6X-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503020450.UW2PuA6X-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/misc/ti_fpc202.c: In function 'fpc202_read':
>> drivers/misc/ti_fpc202.c:104:15: error: implicit declaration of function 'i2c_smbus_read_byte_data' [-Wimplicit-function-declaration]
     104 |         val = i2c_smbus_read_byte_data(priv->client, reg);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/misc/ti_fpc202.c: In function 'fpc202_write':
>> drivers/misc/ti_fpc202.c:110:16: error: implicit declaration of function 'i2c_smbus_write_byte_data' [-Wimplicit-function-declaration]
     110 |         return i2c_smbus_write_byte_data(priv->client, reg, value);
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/misc/ti_fpc202.c: At top level:
>> drivers/misc/ti_fpc202.c:433:1: warning: data definition has no type or storage class
     433 | module_i2c_driver(fpc202_driver);
         | ^~~~~~~~~~~~~~~~~
>> drivers/misc/ti_fpc202.c:433:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Wimplicit-int]
>> drivers/misc/ti_fpc202.c:433:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
>> drivers/misc/ti_fpc202.c:424:26: warning: 'fpc202_driver' defined but not used [-Wunused-variable]
     424 | static struct i2c_driver fpc202_driver = {
         |                          ^~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for I2C_ATR
   Depends on [n]: I2C [=n]
   Selected by [y]:
   - TI_FPC202 [=y]


vim +/i2c_smbus_read_byte_data +104 drivers/misc/ti_fpc202.c

    99	
   100	static int fpc202_read(struct fpc202_priv *priv, u8 reg)
   101	{
   102		int val;
   103	
 > 104		val = i2c_smbus_read_byte_data(priv->client, reg);
   105		return val;
   106	}
   107	
   108	static int fpc202_write(struct fpc202_priv *priv, u8 reg, u8 value)
   109	{
 > 110		return i2c_smbus_write_byte_data(priv->client, reg, value);
   111	}
   112	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki