linux-kernel - Re: [PATCH 1/2] io_uring/rsrc: declare io_find_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADUfDZrOoSgT5n51N5=UFSum96mj2MAytQbJNbBVC1BJrmNVtA@mail.gmail.com>
Date: Fri, 28 Feb 2025 18:04:20 -0800
From: Caleb Sander Mateos <csander@...estorage.com>
To: Pavel Begunkov <asml.silence@...il.com>
Cc: Jens Axboe <axboe@...nel.dk>, io-uring@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] io_uring/rsrc: declare io_find_buf_node() in header file

On Fri, Feb 28, 2025 at 5:45 PM Pavel Begunkov <asml.silence@...il.com> wrote:
>
> On 3/1/25 00:16, Caleb Sander Mateos wrote:
> > Declare io_find_buf_node() in io_uring/rsrc.h so it can be called from
> > other files.
> >
> > Signed-off-by: Caleb Sander Mateos <csander@...estorage.com>
> > ---
> >   io_uring/rsrc.c | 4 ++--
> >   io_uring/rsrc.h | 2 ++
> >   2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
> > index 45bfb37bca1e..4c4f57cd77f9 100644
> > --- a/io_uring/rsrc.c
> > +++ b/io_uring/rsrc.c
> > @@ -1066,12 +1066,12 @@ static int io_import_fixed(int ddir, struct iov_iter *iter,
> >       }
> >
> >       return 0;
> >   }
> >
> > -static inline struct io_rsrc_node *io_find_buf_node(struct io_kiocb *req,
> > -                                                 unsigned issue_flags)
>
> That's a hot path, an extra function call wouldn't be great,
> and it's an internal detail as well. Let's better see what we
> can do with the nop situation.

I can add back inline. With that, there shouldn't be any difference to
the generated instructions for io_import_reg_buf().

>
> btw, don't forget cover letters for series.

Okay, I didn't have much else to add to the brief commit messages. But
sure, I'll add a cover letter in the future.

Best,
Caleb