linux-kernel - Re: [PATCH] iio: adc: Include cleanup.h when using guard()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250302024618.3d01c339@jic23-huawei>
Date: Sun, 2 Mar 2025 02:46:18 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Matti Vaittinen <mazziesaccount@...il.com>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Cosmin
 Tanislav <cosmin.tanislav@...log.com>, Marcelo Schmitt
 <marcelo.schmitt@...log.com>, Matteo Martelli <matteomartelli3@...il.com>,
 Yu Jiaoliang <yujiaoliang@...o.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: Include cleanup.h when using guard()

On Fri, 28 Feb 2025 15:14:03 +0200
Matti Vaittinen <mazziesaccount@...il.com> wrote:

> Directly include the cleanup.h for the guard() instead of relying it to
> be included via other files.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
Applied.  Thanks,

J
> ---
>  drivers/iio/adc/ad4130.c       | 1 +
>  drivers/iio/adc/ad7091r-base.c | 1 +
>  drivers/iio/adc/ad7606.c       | 1 +
>  drivers/iio/adc/max34408.c     | 1 +
>  drivers/iio/adc/pac1921.c      | 1 +
>  5 files changed, 5 insertions(+)
> 
> diff --git a/drivers/iio/adc/ad4130.c b/drivers/iio/adc/ad4130.c
> index de32cc9d18c5..afcea2d6d494 100644
> --- a/drivers/iio/adc/ad4130.c
> +++ b/drivers/iio/adc/ad4130.c
> @@ -6,6 +6,7 @@
>  
>  #include <linux/bitfield.h>
>  #include <linux/bitops.h>
> +#include <linux/cleanup.h>
>  #include <linux/clk.h>
>  #include <linux/clk-provider.h>
>  #include <linux/delay.h>
> diff --git a/drivers/iio/adc/ad7091r-base.c b/drivers/iio/adc/ad7091r-base.c
> index 606486c4dfe8..931ff71b2888 100644
> --- a/drivers/iio/adc/ad7091r-base.c
> +++ b/drivers/iio/adc/ad7091r-base.c
> @@ -7,6 +7,7 @@
>  
>  #include <linux/bitops.h>
>  #include <linux/bitfield.h>
> +#include <linux/cleanup.h>
>  #include <linux/iio/events.h>
>  #include <linux/iio/iio.h>
>  #include <linux/interrupt.h>
> diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c
> index d8e3c7a43678..11505846eb4f 100644
> --- a/drivers/iio/adc/ad7606.c
> +++ b/drivers/iio/adc/ad7606.c
> @@ -5,6 +5,7 @@
>   * Copyright 2011 Analog Devices Inc.
>   */
>  
> +#include <linux/cleanup.h>
>  #include <linux/delay.h>
>  #include <linux/device.h>
>  #include <linux/err.h>
> diff --git a/drivers/iio/adc/max34408.c b/drivers/iio/adc/max34408.c
> index 971e6e5dee9b..4f45fd22a90c 100644
> --- a/drivers/iio/adc/max34408.c
> +++ b/drivers/iio/adc/max34408.c
> @@ -8,6 +8,7 @@
>   */
>  
>  #include <linux/bitfield.h>
> +#include <linux/cleanup.h>
>  #include <linux/init.h>
>  #include <linux/i2c.h>
>  #include <linux/module.h>
> diff --git a/drivers/iio/adc/pac1921.c b/drivers/iio/adc/pac1921.c
> index 90f61c47b1c4..1c28df132e9f 100644
> --- a/drivers/iio/adc/pac1921.c
> +++ b/drivers/iio/adc/pac1921.c
> @@ -7,6 +7,7 @@
>  
>  #include <linux/unaligned.h>
>  #include <linux/bitfield.h>
> +#include <linux/cleanup.h>
>  #include <linux/i2c.h>
>  #include <linux/iio/events.h>
>  #include <linux/iio/iio.h>
> 
> base-commit: d082ecbc71e9e0bf49883ee4afd435a77a5101b6