linux-kernel - Re: [RFC] hwmon: (acpi_power_meter) Replace hwmon_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab93d716-f38c-8e34-cd41-0a35b7db4e43@huawei.com>
Date: Sun, 2 Mar 2025 15:43:32 +0800
From: "lihuisong (C)" <lihuisong@...wei.com>
To: Guenter Roeck <linux@...ck-us.net>
CC: <linux-hwmon@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<zhanjie9@...ilicon.com>, <zhenglifeng1@...wei.com>,
	<liuyonglong@...wei.com>, <jdelvare@...e.com>
Subject: Re: [RFC] hwmon: (acpi_power_meter) Replace hwmon_device_register


在 2025/2/28 22:47, Guenter Roeck 写道:
> On 2/28/25 00:26, lihuisong (C) wrote:
> ...
>>>> BTW, I have another problem as commit log described:
>>>> -->
>>>> The path of these sysfs interfaces are modified accordingly if use 
>>>> hwmon_device_register_with_info():
>>>> Old: all sysfs interfaces are under acpi device, namely, path is 
>>>> "/sys/class/hwmon/hwmon1/device/" ('device' in the path is a soft 
>>>> link of acpi device)
>>>> Now: all sysfs interfaces are under hwmon device, namely, path is 
>>>> "/sys/class/hwmon/hwmon1/"
>>>> What do you think about this?
>>>>
>>>
>>> That is as intended. The ABI states that the attributes are under
>>> /sys/class/hwmon/hwmonX _or_ /sys/class/hwmon/hwmonX/device/.
>>> The ABI does not guarantee that the underlying path remains the same.
>> Yes
>>> libsensors handles this automatically, as should any userspace programs
>>> accessing the attributes directly.
>>>
>>>
>> So we don't need to care or handle this change of syfs path, right?
>>
>
> Correct. Each driver converted to the new API experiences the same 
> change.
> If you insist keeping the path the same, you'll have to drop this effort
> and live with the deprecated message.
>
>
Ok, thanks for your advice and reply.
will send next version ASAP.

/Huisong
>
> .