linux-kernel - Re: [PATCH RFC 1/2] crypto: ti: Add support for SHA224/256/384/512 in DTHE V2 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8QSVLoucZxG1xlc@gondor.apana.org.au>
Date: Sun, 2 Mar 2025 16:09:56 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: T Pratham <t-pratham@...com>
Cc: "David S. Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, Vignesh Raghavendra <vigneshr@...com>,
	Praneeth Bajjuri <praneeth@...com>,
	Kamlesh Gurudasani <kamlesh@...com>,
	Manorit Chawdhry <m-chawdhry@...com>
Subject: Re: [PATCH RFC 1/2] crypto: ti: Add support for SHA224/256/384/512
 in DTHE V2 driver

On Tue, Feb 18, 2025 at 04:19:42PM +0530, T Pratham wrote:
>
> +struct dthe_hash_ctx {
> +	enum dthe_hash_algSel mode;
> +	u16 block_size;
> +	u8 digest_size;
> +	u8 phash_available;
> +	u32 phash[SHA512_DIGEST_SIZE / sizeof(u32)];

Is this format identical to the software sha512 hash? If so please
make the export/import functions translate to and from struct
sha512_state.

That way we can export and resume using the software sha512 in case
something goes wrong (e.g., memory allocation failure).

Ditto with all the other hash algorithms.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt