| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <b92c0f59-c721-4e91-ac41-267a81758916@kwiboo.se>
Date: Sun, 2 Mar 2025 12:33:53 +0100
From: Jonas Karlman <jonas@...boo.se>
To: Yao Zi <ziyao@...root.org>
Cc: Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
Michael Turquette <mturquette@...libre.com>, Stephen Boyd
<sboyd@...nel.org>, Frank Wang <frank.wang@...k-chips.com>,
Shresth Prasad <shresthprasad7@...il.com>,
Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
Detlev Casanova <detlev.casanova@...labora.com>, linux-mmc@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-clk@...r.kernel.org
Subject: Re: [PATCH 7/8] arm64: dts: rockchip: Add SDMMC/SDIO controllers for
RK3528
Hi Yao Zi,
On 2025-03-01 14:33, Yao Zi wrote:
> On Sat, Mar 01, 2025 at 01:47:47PM +0100, Jonas Karlman wrote:
>> Hi,
>>
>> On 2025-03-01 11:47, Yao Zi wrote:
>>> RK3528 features two SDIO controllers and one SD/MMC controller, describe
>>> them in devicetree. Since their sample and drive clocks are located in
>>> the VO and VPU GRFs, corresponding syscons are added to make these
>>> clocks available.
>>>
>>> Signed-off-by: Yao Zi <ziyao@...root.org>
>>> ---
>>> arch/arm64/boot/dts/rockchip/rk3528.dtsi | 62 ++++++++++++++++++++++++
>>> 1 file changed, 62 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3528.dtsi b/arch/arm64/boot/dts/rockchip/rk3528.dtsi
>>> index 5b334690356a..078c97fa1d9f 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3528.dtsi
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3528.dtsi
>>> @@ -7,6 +7,7 @@
>>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> #include <dt-bindings/interrupt-controller/irq.h>
>>> #include <dt-bindings/clock/rockchip,rk3528-cru.h>
>>> +#include <dt-bindings/reset/rockchip,rk3528-cru.h>
>>>
>>> / {
>>> compatible = "rockchip,rk3528";
>>> @@ -122,6 +123,16 @@ gic: interrupt-controller@...01000 {
>>> #interrupt-cells = <3>;
>>> };
>>>
>>> + vpu_grf: syscon@...40000 {
>>> + compatible = "rockchip,rk3528-vpu-grf", "syscon";
>>
>> vpu_grf is also used for gmac1, so should possible be a "syscon",
>> "simple-mfd", or have I misunderstood when to use simple-mfd ?
>
> Just as Heiko explained, "simple-mfd" is only required when the child
> nodes should be populated automatically. Here these two GRFs are only
> referenced and have no child, thus "simple-mfd" compatible isn't useful.
Thanks for the explanations.
>
>>> + reg = <0x0 0xff340000 0x0 0x8000>;
>>> + };
>>> +
>>> + vo_grf: syscon@...60000 {
>>> + compatible = "rockchip,rk3528-vo-grf", "syscon";
>>
>> similar here, vo_grf is also used for gmac0.
>>
>>> + reg = <0x0 0xff360000 0x0 0x10000>;
>>> + };
>>> +
>>> cru: clock-controller@...a0000 {
>>> compatible = "rockchip,rk3528-cru";
>>> reg = <0x0 0xff4a0000 0x0 0x30000>;
>>> @@ -251,5 +262,56 @@ uart7: serial@...28000 {
>>> reg-shift = <2>;
>>> status = "disabled";
>>> };
>>> +
>>> + sdio0: mmc@...10000 {
>>> + compatible = "rockchip,rk3528-dw-mshc",
>>> + "rockchip,rk3288-dw-mshc";
>>> + reg = <0x0 0xffc10000 0x0 0x4000>;
>>> + clocks = <&cru HCLK_SDIO0>,
>>> + <&cru CCLK_SRC_SDIO0>,
>>> + <&cru SCLK_SDIO0_DRV>,
>>> + <&cru SCLK_SDIO0_SAMPLE>;
>>> + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample";
>>> + fifo-depth = <0x100>;
>>> + interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
>>> + max-frequency = <150000000>;
>>> + resets = <&cru SRST_H_SDIO0>;
>>> + reset-names = "reset";
>>> + status = "disabled";
>>> + };
>>> +
>>> + sdio1: mmc@...20000 {
>>> + compatible = "rockchip,rk3528-dw-mshc",
>>> + "rockchip,rk3288-dw-mshc";
>>> + reg = <0x0 0xffc20000 0x0 0x4000>;
>>> + clocks = <&cru HCLK_SDIO1>,
>>> + <&cru CCLK_SRC_SDIO1>,
>>> + <&cru SCLK_SDIO1_DRV>,
>>> + <&cru SCLK_SDIO1_SAMPLE>;
>>> + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample";
>>> + fifo-depth = <0x100>;
>>> + interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
>>> + max-frequency = <150000000>;
>>> + resets = <&cru SRST_H_SDIO1>;
>>> + reset-names = "reset";
>>> + status = "disabled";
>>> + };
>>> +
>>> + sdmmc: mmc@...30000 {
>>> + compatible = "rockchip,rk3528-dw-mshc",
>>> + "rockchip,rk3288-dw-mshc";
>>> + reg = <0x0 0xffc30000 0x0 0x4000>;
>>> + clocks = <&cru HCLK_SDMMC0>,
>>> + <&cru CCLK_SRC_SDMMC0>,
>>> + <&cru SCLK_SDMMC_DRV>,
>>> + <&cru SCLK_SDMMC_SAMPLE>;
>>> + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample";
>>> + fifo-depth = <0x100>;
>>> + interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
>>> + max-frequency = <150000000>;
>>> + resets = <&cru SRST_H_SDMMC0>;
>>> + reset-names = "reset";
>>
>> Suggest adding default pinctrl props here:
>>
>> pinctrl-names = "default";
>> pinctrl-0 = <&sdmmc_bus4>, <&sdmmc_clk>, <&sdmmc_cmd>, <&sdmmc_det>;
>>
>> And possible also for sdio0 and sdio1.
>>
>> Regards,
>> Jonas
>
> It makes sense. As mentioned in the cover letter, I depended on the
> bootloader to setup pinctrl, to minimize dependency of the series.
BootROM typically setup pinctrl for the storage media when probing for
idblock and mainline U-Boot will setup pinctrl based on the board device
tree synced from Linux. Adding pinctrl early in Linux will help avoid a
need for using workarounds in U-Boot.
For RK3528 there only seem to be one option for sdmmc/sdio pins, adding
a default to soc dtsi should help reduce duplication in future board
device trees.
>
> Will complete the pinctrl properties in next version.
Thanks :-)
Regards,
Jonas
>
>>> + status = "disabled";
>>> + };
>>> };
>>> };
>>
>
> Best regards,
> Yao Zi
Powered by blists - more mailing lists