linux-kernel - Re: [PATCH 0/4] cifs: Handle all name surrogate reparse points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250302122446.dpqd6hlpfmy3fo3l@pali>
Date: Sun, 2 Mar 2025 13:24:46 +0100
From: Pali Rohár <pali@...nel.org>
To: Steve French <smfrench@...il.com>
Cc: Steve French <sfrench@...ba.org>, Paulo Alcantara <pc@...guebit.com>,
	Ronnie Sahlberg <ronniesahlberg@...il.com>,
	linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] cifs: Handle all name surrogate reparse points

On Sunday 23 February 2025 18:48:50 Steve French wrote:
> On Sun, Feb 23, 2025 at 4:23 PM Pali Rohár <pali@...nel.org> wrote:
> >
> > Hello Steve, I see that you have merged first two changes (1/4 and 2/4)
> > from this patch series, but the remaining (3/4 and 4/4). Is there any
> > reason why 3/4 and 4/4 was not taken?
> 
> Mainly because I wasn't able to easily test it, and didn't get test
> feedback for anyone else
> on those two who had tried it.
> 
> I am ok with looking at them again - and thx for rebasing.

Ok, when you have a time, please look at them.

> There are some of the 41 patches in your updated cifs branch that do look suitable or rc5

There is "cifs: Change translation of STATUS_DELETE_PENDING to -EBUSY"
which stops returning -ENOENT for directory entry which still exists.

> 
> > On Sunday 22 December 2024 15:58:41 Pali Rohár wrote:
> > > Name surrogate reparse point represents another named entity in the system.
> > >
> > > If the name surrogate reparse point is not handled by Linux SMB client
> > > and it is of directory type then treat it as a new mount point.
> > >
> > > Cleanup code for all explicit surrogate reparse points (like reparse
> > > points with tag IO_REPARSE_TAG_MOUNT_POINT) as they are handled by
> > > generic name surrogate reparse point code.
> > >
> > > Pali Rohár (4):
> > >   cifs: Throw -EOPNOTSUPP error on unsupported reparse point type from
> > >     parse_reparse_point()
> > >   cifs: Treat unhandled directory name surrogate reparse points as mount
> > >     directory nodes
> > >   cifs: Remove explicit handling of IO_REPARSE_TAG_MOUNT_POINT in
> > >     inode.c
> > >   cifs: Improve handling of name surrogate reparse points in reparse.c
> > >
> > >  fs/smb/client/inode.c    | 17 +++++++++++++----
> > >  fs/smb/client/reparse.c  | 24 ++++++++++--------------
> > >  fs/smb/common/smbfsctl.h |  3 +++
> > >  3 files changed, 26 insertions(+), 18 deletions(-)
> > >
> > > --
> > > 2.20.1
> > >
> >
> 
> 
> -- 
> Thanks,
> 
> Steve