linux-kernel - Re: [PATCH 2/3] usb: typec: ps883x: fix missing accessibility check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c6f9c8c-3d03-45d3-b601-989e6c441501@oldschoolsolutions.biz>
Date: Sun, 2 Mar 2025 14:34:41 +0100
From: Jens Glathe <jens.glathe@...schoolsolutions.biz>
To: Johan Hovold <johan+linaro@...nel.org>,
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Abel Vesa <abel.vesa@...aro.org>,
 Stephan Gerhold <stephan.gerhold@...aro.org>, linux-arm-msm@...r.kernel.org,
 linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] usb: typec: ps883x: fix missing accessibility check

Hi Johan,

On 2/18/25 16:29, Johan Hovold wrote:
> Make sure that the retimer is accessible before registering to avoid
> having later consumer calls fail to configure it, something which, for
> example, can lead to a hotplugged display not being recognised:
>
> 	[drm:msm_dp_panel_read_sink_caps [msm]] *ERROR* read dpcd failed -110
>
> Fixes: 257a087c8b52 ("usb: typec: Add support for Parade PS8830 Type-C Retimer")
> Cc: Abel Vesa <abel.vesa@...aro.org>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>

unfortunately, this one goes south on the HP Omnibook X14, and also on
the Elitebook G1Q. After excluding a lot of other causes, like inverted
resets and wrong i2c channels, I did a bisect and landed at this commit.

Looking at it, I speculatively increased the firmware initialization
delay to 200ms. To no effect. Reverting this patch "resolves" the issue.

with best regards

Jens