linux-kernel - Re: [PATCH] kunit: constify return of string literals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ2a_Dc1-KSsV9aS8P0x4SePRrjO228wRF=4=5f18wAk0G+AAQ@mail.gmail.com>
Date: Sun, 2 Mar 2025 16:47:26 +0100
From: Christian Göttsche <cgzones@...glemail.com>
To: cgzones@...glemail.com
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, David Gow <davidgow@...gle.com>, 
	Rae Moar <rmoar@...gle.com>, Nathan Chancellor <nathan@...nel.org>, 
	Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling <morbo@...gle.com>, 
	Justin Stitt <justinstitt@...gle.com>, linux-kselftest@...r.kernel.org, 
	kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org, 
	llvm@...ts.linux.dev
Subject: Re: [PATCH] kunit: constify return of string literals

On Tue, 26 Nov 2024 at 12:36, Christian Göttsche
<cgoettsche@...tendoof.de> wrote:
>
> From: Christian Göttsche <cgzones@...glemail.com>
>
> The function kunit_status_to_ok_not_ok() returns string literals, thus
> declare the return value as such.
>
> Reported by clang:
>
>     ./include/kunit/test.h:143:10: warning: returning 'const char[3]' from a function with result type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
>       143 |                 return "ok";
>           |                        ^~~~
>     ./include/kunit/test.h:145:10: warning: returning 'const char[7]' from a function with result type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
>       145 |                 return "not ok";
>           |                        ^~~~~~~~
>     ./include/kunit/test.h:147:9: warning: returning 'const char[8]' from a function with result type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
>       147 |         return "invalid";
>           |                ^~~~~~~~~
>
> Signed-off-by: Christian Göttsche <cgzones@...glemail.com>

Kindly ping.

> ---
>  include/kunit/test.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/kunit/test.h b/include/kunit/test.h
> index 34b71e42fb10..ae1b57578476 100644
> --- a/include/kunit/test.h
> +++ b/include/kunit/test.h
> @@ -135,7 +135,7 @@ struct kunit_case {
>         struct string_stream *log;
>  };
>
> -static inline char *kunit_status_to_ok_not_ok(enum kunit_status status)
> +static inline const char *kunit_status_to_ok_not_ok(enum kunit_status status)
>  {
>         switch (status) {
>         case KUNIT_SKIPPED:
> --
> 2.45.2
>