[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <cover.1740932040.git.christophe.jaillet@wanadoo.fr>
Date: Sun, 2 Mar 2025 17:21:33 +0100
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: andersson@...nel.org,
Michael.Srba@...nam.cz,
konradybcio@...nel.org,
jeffrey.l.hugo@...il.com
Cc: linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org,
Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: [PATCH 0/2] bus: qcom-ssc-block-bus: Fix some error handling paths
Patch 1 should be straight forward. It removes some ioumap() from
resources allocated with devm_ioremap_resource().
Patch 2 is more speculative. It releases some resources in the error
handling path of the probe, as done in the .remove() function.
Finally, the .remove() function also has some
pm_runtime_disable(&pdev->dev);
pm_clk_destroy(&pdev->dev);
calls.
Usually pm_runtime_disable() is paired with pm_runtime_enable() and I
would expect some pm_clk_add(() calls related to pm_clk_destroy().
Neither exists.
So I wonder if these 2 calls are correct in the .remove() function.
Thought?
Christophe JAILLET (2):
bus: qcom-ssc-block-bus: Remove some duplicated iounmap() calls
bus: qcom-ssc-block-bus: Fix the error handling path of
qcom_ssc_block_bus_probe()
drivers/bus/qcom-ssc-block-bus.c | 34 ++++++++++++++++++--------------
1 file changed, 19 insertions(+), 15 deletions(-)
--
2.48.1
Powered by blists - more mailing lists