linux-kernel - [PATCH] platform/x86: samsung-galaxybook: Fix block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250302205350.32509-1-josh@joshuagrisham.com>
Date: Sun,  2 Mar 2025 21:53:50 +0100
From: Joshua Grisham <josh@...huagrisham.com>
To: W_Armin@....de,
	thomas@...ch.de,
	kuurtb@...il.com,
	ilpo.jarvinen@...ux.intel.com,
	hdegoede@...hat.com,
	platform-driver-x86@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: Joshua Grisham <josh@...huagrisham.com>
Subject: [PATCH] platform/x86: samsung-galaxybook: Fix block_recording not supported logic

Fixes logic error when block_recording is not supported but the fw attr is
being added anyway (reported by GitHub user bbregeault).

Signed-off-by: Joshua Grisham <josh@...huagrisham.com>
---
 drivers/platform/x86/samsung-galaxybook.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/samsung-galaxybook.c b/drivers/platform/x86/samsung-galaxybook.c
index de1ed2dc6..5878a3519 100644
--- a/drivers/platform/x86/samsung-galaxybook.c
+++ b/drivers/platform/x86/samsung-galaxybook.c
@@ -1100,11 +1100,13 @@ static int galaxybook_fw_attrs_init(struct samsung_galaxybook *galaxybook)
 	}
 
 	err = galaxybook_block_recording_init(galaxybook);
-	if (!err)
-		galaxybook->has_block_recording = true;
-	else if (err != GB_NOT_SUPPORTED)
+	if (err == GB_NOT_SUPPORTED)
+		return 0;
+	else if (err)
 		return err;
 
+	galaxybook->has_block_recording = true;
+
 	return galaxybook_fw_attr_init(galaxybook,
 				       GB_ATTR_BLOCK_RECORDING,
 				       &block_recording_acpi_get,
-- 
2.45.2