linux-kernel - Re: [v2] genirq/msi: Add the address and data that show MSI/MSIX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202503020807.c3MhmbJh-lkp@intel.com>
Date: Sun, 2 Mar 2025 09:12:05 +0800
From: kernel test robot <lkp@...el.com>
To: Hans Zhang <18255117159@....com>, tglx@...utronix.de
Cc: oe-kbuild-all@...ts.linux.dev, manivannan.sadhasivam@...aro.org,
	kw@...ux.com, kwilczynski@...nel.org, bhelgaas@...gle.com,
	Frank.Li@....com, cassel@...nel.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, Hans Zhang <18255117159@....com>
Subject: Re: [v2] genirq/msi: Add the address and data that show MSI/MSIX

Hi Hans,

kernel test robot noticed the following build errors:

[auto build test ERROR on 76544811c850a1f4c055aa182b513b7a843868ea]

url:    https://github.com/intel-lab-lkp/linux/commits/Hans-Zhang/genirq-msi-Add-the-address-and-data-that-show-MSI-MSIX/20250301-204332
base:   76544811c850a1f4c055aa182b513b7a843868ea
patch link:    https://lore.kernel.org/r/20250301123953.291675-1-18255117159%40163.com
patch subject: [v2] genirq/msi: Add the address and data that show MSI/MSIX
config: x86_64-buildonly-randconfig-003-20250302 (https://download.01.org/0day-ci/archive/20250302/202503020807.c3MhmbJh-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250302/202503020807.c3MhmbJh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503020807.c3MhmbJh-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/irq/msi.c: In function 'msi_domain_debug_show':
>> kernel/irq/msi.c:770:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
     770 |         seq_printf(m, "%*s%s:", ind, "", is_msix ? "msix" : "msi");
         |         ^~~~~~~~~~
         |         bstr_printf
   kernel/irq/msi.c: At top level:
>> kernel/irq/msi.c:782:10: error: 'const struct irq_domain_ops' has no member named 'debug_show'
     782 |         .debug_show     = msi_domain_debug_show,
         |          ^~~~~~~~~~
>> kernel/irq/msi.c:782:27: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     782 |         .debug_show     = msi_domain_debug_show,
         |                           ^~~~~~~~~~~~~~~~~~~~~
   kernel/irq/msi.c:782:27: note: (near initialization for 'msi_domain_ops')
   kernel/irq/msi.c:782:27: error: initialization of 'int (*)(struct irq_domain *, unsigned int,  unsigned int,  void *)' from incompatible pointer type 'void (*)(struct seq_file *, struct irq_domain *, struct irq_data *, int)' [-Werror=incompatible-pointer-types]
   kernel/irq/msi.c:782:27: note: (near initialization for 'msi_domain_ops.alloc')
   kernel/irq/msi.c:782:27: warning: initialized field overwritten [-Woverride-init]
   kernel/irq/msi.c:782:27: note: (near initialization for 'msi_domain_ops.alloc')
   cc1: some warnings being treated as errors


vim +770 kernel/irq/msi.c

   758	
   759	static void msi_domain_debug_show(struct seq_file *m, struct irq_domain *d,
   760					  struct irq_data *irqd, int ind)
   761	{
   762		struct msi_desc *desc;
   763		bool is_msix;
   764	
   765		desc = irq_get_msi_desc(irqd->irq);
   766		if (!desc)
   767			return;
   768	
   769		is_msix = desc->pci.msi_attrib.is_msix;
 > 770		seq_printf(m, "%*s%s:", ind, "", is_msix ? "msix" : "msi");
   771		seq_printf(m, "\n%*saddress_hi: 0x%08x", ind + 1, "", desc->msg.address_hi);
   772		seq_printf(m, "\n%*saddress_lo: 0x%08x", ind + 1, "", desc->msg.address_lo);
   773		seq_printf(m, "\n%*smsg_data:   0x%08x\n", ind + 1, "", desc->msg.data);
   774	}
   775	
   776	static const struct irq_domain_ops msi_domain_ops = {
   777		.alloc		= msi_domain_alloc,
   778		.free		= msi_domain_free,
   779		.activate	= msi_domain_activate,
   780		.deactivate	= msi_domain_deactivate,
   781		.translate	= msi_domain_translate,
 > 782		.debug_show     = msi_domain_debug_show,
   783	};
   784	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki