linux-kernel - [PATCH] PM: sleep: wakeirq: Introduce device-managed devm_pm_set_dedicated_wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250304110930.2034394-1-xu.yang_2@nxp.com>
Date: Tue,  4 Mar 2025 19:09:30 +0800
From: Xu Yang <xu.yang_2@....com>
To: rafael@...nel.org,
	len.brown@...el.com,
	pavel@...nel.org,
	gregkh@...uxfoundation.org,
	dakr@...nel.org
Cc: linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev
Subject: [PATCH] PM: sleep: wakeirq: Introduce device-managed devm_pm_set_dedicated_wake_irq()

Add device-managed variant of dev_pm_set_dedicated_wake_irq() and
dev_pm_set_dedicated_wake_irq_reverse() which automatically
free and clear the wake irq on device destruction to simplify error
handling.

Signed-off-by: Xu Yang <xu.yang_2@....com>
---
 drivers/base/power/wakeirq.c | 43 ++++++++++++++++++++++++++++++++++++
 include/linux/pm_wakeirq.h   | 12 ++++++++++
 2 files changed, 55 insertions(+)

diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c
index 8aa28c08b289..dc2c9cbf40e9 100644
--- a/drivers/base/power/wakeirq.c
+++ b/drivers/base/power/wakeirq.c
@@ -129,6 +129,49 @@ int devm_pm_set_wake_irq(struct device *dev, int irq)
 }
 EXPORT_SYMBOL_GPL(devm_pm_set_wake_irq);
 
+/**
+ * devm_pm_set_dedicated_wake_irq - device-managed variant of
+ *                                  dev_pm_set_dedicated_wake_irq
+ * @dev: Device entry
+ * @irq: Device IO interrupt
+ *
+ * Request a dedicated wake-up interrupt, same with dev_pm_set_dedicated_wake_irq,
+ * but the device will be auto clear wake capability on driver detach.
+ */
+int devm_pm_set_dedicated_wake_irq(struct device *dev, int irq)
+{
+	int ret;
+
+	ret = dev_pm_set_dedicated_wake_irq(dev, irq);
+	if (ret)
+		return ret;
+
+	return devm_add_action_or_reset(dev, devm_pm_clear_wake_irq, dev);
+}
+EXPORT_SYMBOL_GPL(devm_pm_set_dedicated_wake_irq);
+
+/**
+ * devm_pm_set_dedicated_wake_irq_reverse - device-managed variant of
+ *                                          dev_pm_set_dedicated_wake_irq_reverse
+ * @dev: Device entry
+ * @irq: Device IO interrupt
+ *
+ * Request a dedicated wake-up interrupt with reverse enable ordering, same with
+ * dev_pm_set_dedicated_wake_irq_reverse, but the device will be auto clear wake
+ * capability on driver detach.
+ */
+int devm_pm_set_dedicated_wake_irq_reverse(struct device *dev, int irq)
+{
+	int ret;
+
+	ret = dev_pm_set_dedicated_wake_irq_reverse(dev, irq);
+	if (ret)
+		return ret;
+
+	return devm_add_action_or_reset(dev, devm_pm_clear_wake_irq, dev);
+}
+EXPORT_SYMBOL_GPL(devm_pm_set_dedicated_wake_irq_reverse);
+
 /**
  * handle_threaded_wake_irq - Handler for dedicated wake-up interrupts
  * @irq: Device specific dedicated wake-up interrupt
diff --git a/include/linux/pm_wakeirq.h b/include/linux/pm_wakeirq.h
index 25b63ed51b76..98a532cd92fe 100644
--- a/include/linux/pm_wakeirq.h
+++ b/include/linux/pm_wakeirq.h
@@ -11,6 +11,8 @@ extern int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq);
 extern int dev_pm_set_dedicated_wake_irq_reverse(struct device *dev, int irq);
 extern void dev_pm_clear_wake_irq(struct device *dev);
 extern int devm_pm_set_wake_irq(struct device *dev, int irq);
+extern int devm_pm_set_dedicated_wake_irq(struct device *dev, int irq);
+extern int devm_pm_set_dedicated_wake_irq_reverse(struct device *dev, int irq);
 
 #else	/* !CONFIG_PM */
 
@@ -38,5 +40,15 @@ static inline int devm_pm_set_wake_irq(struct device *dev, int irq)
 	return 0;
 }
 
+static inline int devm_pm_set_dedicated_wake_irq(struct device *dev, int irq)
+{
+	return 0;
+}
+
+static inline int devm_pm_set_dedicated_wake_irq_reverse(struct device *dev, int irq)
+{
+	return 0;
+}
+
 #endif	/* CONFIG_PM */
 #endif	/* _LINUX_PM_WAKEIRQ_H */
-- 
2.34.1