linux-kernel - Re: [PATCH 2/2] irq/irq-loongarch-ir:Add Redirect irqchip support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202503041913.hIveXcmc-lkp@intel.com>
Date: Tue, 4 Mar 2025 19:24:27 +0800
From: kernel test robot <lkp@...el.com>
To: Tianyang Zhang <zhangtianyang@...ngson.cn>, chenhuacai@...nel.org,
	kernel@...0n.name, corbet@....net, alexs@...nel.org,
	si.yanteng@...ux.dev, tglx@...utronix.de, jiaxun.yang@...goat.com,
	peterz@...radead.org, wangliupu@...ngson.cn, lvjianmin@...ngson.cn,
	maobibo@...ngson.cn, siyanteng@...oftware.com.cn,
	gaosong@...ngson.cn, yangtiezhu@...ngson.cn
Cc: oe-kbuild-all@...ts.linux.dev, loongarch@...ts.linux.dev,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tianyang Zhang <zhangtianyang@...ngson.cn>
Subject: Re: [PATCH 2/2] irq/irq-loongarch-ir:Add Redirect irqchip support

Hi Tianyang,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/irq/core]
[also build test ERROR on lwn/docs-next linus/master v6.14-rc5 next-20250303]
[cannot apply to tip/smp/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tianyang-Zhang/Docs-LoongArch-Add-Advanced-Extended-Redirect-IRQ-model-description/20250303-181832
base:   tip/irq/core
patch link:    https://lore.kernel.org/r/20250303101533.31462-3-zhangtianyang%40loongson.cn
patch subject: [PATCH 2/2] irq/irq-loongarch-ir:Add Redirect irqchip support
config: loongarch-randconfig-002-20250304 (https://download.01.org/0day-ci/archive/20250304/202503041913.hIveXcmc-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250304/202503041913.hIveXcmc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503041913.hIveXcmc-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/irqchip/irq-loongarch-ir.c: In function 'loongarch_irq_redirect_alloc':
>> drivers/irqchip/irq-loongarch-ir.c:352:52: error: 'struct device' has no member named 'numa_node'
     352 |         node = ((msi_alloc_info_t *)arg)->desc->dev->numa_node;
         |                                                    ^~


vim +352 drivers/irqchip/irq-loongarch-ir.c

   342	
   343	static int loongarch_irq_redirect_alloc(struct irq_domain *domain,
   344						unsigned int virq, unsigned int nr_irqs,
   345						 void *arg)
   346	{
   347		struct redirect_table *ird_table;
   348		struct avecintc_data *avec_data;
   349		struct irq_data *irq_data;
   350		int ret, i, node;
   351	
 > 352		node = ((msi_alloc_info_t *)arg)->desc->dev->numa_node;
   353		ird_table = &irde_descs[node].ird_table;
   354		ret = irq_domain_alloc_irqs_parent(domain, virq, nr_irqs, arg);
   355		if (ret < 0)
   356			return ret;
   357	
   358		for (i = 0; i < nr_irqs; i++) {
   359			struct redirect_item *item;
   360	
   361			item = kzalloc(sizeof(struct redirect_item), GFP_KERNEL);
   362			if (!item) {
   363				pr_err("Alloc redirect descriptor failed\n");
   364				goto out_free_resources;
   365			}
   366	
   367			irq_data = irq_domain_get_irq_data(domain, virq + i);
   368	
   369			avec_data = irq_data_get_avec_data(irq_data);
   370			ret = redirect_table_alloc(item, ird_table);
   371			if (ret) {
   372				pr_err("Alloc redirect table entry failed\n");
   373				goto out_free_resources;
   374			}
   375	
   376			item->gpid = kzalloc_node(sizeof(struct redirect_gpid), GFP_KERNEL, node);
   377			if (!item->gpid) {
   378				pr_err("Alloc redirect GPID failed\n");
   379				goto out_free_resources;
   380			}
   381	
   382			irq_data->chip_data = item;
   383			irq_data->chip = &loongarch_redirect_chip;
   384			redirect_domain_prepare_entry(item, avec_data);
   385		}
   386		return 0;
   387	
   388	out_free_resources:
   389		loongarch_irq_redirect_free_resources(domain, virq, nr_irqs);
   390		irq_domain_free_irqs_common(domain, virq, nr_irqs);
   391	
   392		return -EINVAL;
   393	}
   394	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki