linux-kernel - Re: [PATCH] qlcnic: fix a memory leak in qlcnic_sriov_set_guest_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63e68624-3672-4473-be15-ce04eb3cd2ed@redhat.com>
Date: Tue, 4 Mar 2025 12:28:29 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Haoxiang Li <haoxiang_li2024@....com>, shshaikh@...vell.com,
 manishc@...vell.com, GR-Linux-NIC-Dev@...vell.com, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 rajesh.borundia@...gic.com, sucheta.chakraborty@...gic.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH] qlcnic: fix a memory leak in
 qlcnic_sriov_set_guest_vlan_mode()


On 2/28/25 10:24 AM, Haoxiang Li wrote:
> Add qlcnic_sriov_free_vlans() to free the memory allocated by
> qlcnic_sriov_alloc_vlans() if "sriov->allowed_vlans" fails to
> be allocated.
> 
> Fixes: 91b7282b613d ("qlcnic: Support VLAN id config.")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@....com>

AFAICS the fix is not complete: sriov vlans could still be leaked when
qlcnic_sriov_alloc_vlans() fails on any VF with id > 0.

Please handle even such scenario.

Thanks!

Paolo