linux-kernel - Re: [PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller on Sophgo SG2044

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8boTsGU-o2MwNZ2@smile.fi.intel.com>
Date: Tue, 4 Mar 2025 13:47:26 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Inochi Amaoto <inochiama@...il.com>
Cc: Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	Yixun Lan <dlan@...too.org>, Longbin Li <looong.bin@...il.com>
Subject: Re: [PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller
 on Sophgo SG2044

On Tue, Mar 04, 2025 at 01:43:27PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 04, 2025 at 03:02:11PM +0800, Inochi Amaoto wrote:
> > Add ACPI ID for DWAPB I2C controller on Sophgo SG2044 so
> > the SoC can enumerated the device via ACPI.
> 
> Same as per UART:
> 
> ---8<---
> 
> This is fake ACPI ID. Please work with a vendor to issue the proper one.
> Vendor ACPI ID registry has no records on Sophgo:
> https://uefi.org/ACPI_ID_List?acpi_search=SophGo
> 
> NAK.
> 
> ---8<---
> 
> But, it might be that is already in the process of getting proper ACPI vendor
> ID, please provide an evidence in such a case.

Looking even closer to the ID, it is completely bogus as it uses CAPITAL O
instead of 0 in device ID part.

> Otherwise drag the representative of the vendor to this email thread to answer
> the question why the heck they abuse ACPI specification.

So, go and work with the vendor to fix their misunderstanding of ACPI and tell
them that they are free to contact me for the details. I will glad to help them
to make right things right.

Also read this success story of similar case:
https://andy-shev.dreamwidth.org/151340.html
and feel free to share with the vendor.

-- 
With Best Regards,
Andy Shevchenko