linux-kernel - Re: [PATCH net-next v2 2/8] netconsole: Make boolean comparison consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250304115023.GB3666230@kernel.org>
Date: Tue, 4 Mar 2025 11:50:23 +0000
From: Simon Horman <horms@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>, Shuah Khan <shuah@...nel.org>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kselftest@...r.kernel.org,
	kernel-team@...a.com
Subject: Re: [PATCH net-next v2 2/8] netconsole: Make boolean comparison
 consistent

On Fri, Feb 28, 2025 at 04:50:18AM -0800, Breno Leitao wrote:
> Convert the current state assignment to use explicit boolean conversion,
> making the code more robust and easier to read. This change adds a
> double-negation operator to ensure consistent boolean conversion as
> suggested by Paolo[1].
> 
> This approach aligns with the existing pattern used in
> sysdata_cpu_nr_enabled_show().
> 
> Link: https://lore.kernel.org/all/7309e760-63b0-4b58-ad33-2fb8db361141@redhat.com/ [1]
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Thanks Breno,

FWIIW, I 100% agree with this change.

Reviewed-by: Simon Horman <horms@...nel.org>