linux-kernel - Re: [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tt89gfe4.fsf@kernel.org>
Date: Tue, 04 Mar 2025 13:16:19 +0100
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Guilherme Giacomo Simoes" <trintaeoitogc@...il.com>
Cc: <alex.gaynor@...il.com>,  <aliceryhl@...gle.com>,  <apw@...onical.com>,
  <arnd@...db.de>,  <aswinunni01@...il.com>,  <axboe@...nel.dk>,
  <benno.lossin@...ton.me>,  <bhelgaas@...gle.com>,
  <bjorn3_gh@...tonmail.com>,  <boqun.feng@...il.com>,  <dakr@...nel.org>,
  <dwaipayanray1@...il.com>,  <ethan.twardy@...il.com>,
  <fujita.tomonori@...il.com>,  <gary@...yguo.net>,
  <gregkh@...uxfoundation.org>,  <joe@...ches.com>,
  <lukas.bulwahn@...il.com>,  <ojeda@...nel.org>,  <pbonzini@...hat.com>,
  <tmgross@...ch.edu>,  <walmeida@...rosoft.com>,
  <rust-for-linux@...r.kernel.org>,  <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules

"Guilherme Giacomo Simoes" <trintaeoitogc@...il.com> writes:

> Implement a check to ensure that the author, firmware, and alias fields
> of the module! macro are properly formatted.
>
> * If the array contains more than one value, enforce vertical
>   formatting.
> * If the array contains only one value, it may be formatted on a single
>   line
>
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>

Tested-by: Andreas Hindborg <a.hindborg@...nel.org>

Does what it says on the label. However, indentation is not checked and
the following is passing:

    authors: [
        "John Doe",
              "Foo Bar"
    ],

Another thing: I'm wondering if we could have a rust hostprog to do
this check, rather than a perl script?


Best regards,
Andreas Hindborg