linux-kernel - [PATCH hyperv-next v2 1/1] scsi: storvsc: Don't report the host packet status as the hv status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250304000940.9557-2-romank@linux.microsoft.com>
Date: Mon,  3 Mar 2025 16:09:40 -0800
From: Roman Kisel <romank@...ux.microsoft.com>
To: eahariha@...ux.microsoft.com,
	mhklinux@...look.com,
	kys@...rosoft.com,
	haiyangz@...rosoft.com,
	wei.liu@...nel.org,
	decui@...rosoft.com,
	James.Bottomley@...senPartnership.com,
	martin.petersen@...cle.com,
	linux-hyperv@...r.kernel.org,
	linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: apais@...rosoft.com,
	benhill@...rosoft.com,
	sunilmut@...rosoft.com
Subject: [PATCH hyperv-next v2 1/1] scsi: storvsc: Don't report the host packet status as the hv status

The log statement reports the packet status code as the hv
status code which causes confusion when debugging as "hv"
might refer to a hypervisor, and sometimes to the host part
of the Hyper-V virtualization stack.

Fix the name of the datum being logged to clearly indicate
the component reporting the error. Also log it in hexadecimal
everywhere for consistency.

Signed-off-by: Roman Kisel <romank@...ux.microsoft.com>
---
 drivers/scsi/storvsc_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index a8614e54544e..35db061ae3ec 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -776,7 +776,7 @@ static void  handle_multichannel_storage(struct hv_device *device, int max_chns)
 
 	if (vstor_packet->operation != VSTOR_OPERATION_COMPLETE_IO ||
 	    vstor_packet->status != 0) {
-		dev_err(dev, "Failed to create sub-channel: op=%d, sts=%d\n",
+		dev_err(dev, "Failed to create sub-channel: op=%d, host=0x%x\n",
 			vstor_packet->operation, vstor_packet->status);
 		return;
 	}
@@ -1183,7 +1183,7 @@ static void storvsc_on_io_completion(struct storvsc_device *stor_device,
 			STORVSC_LOGGING_WARN : STORVSC_LOGGING_ERROR;
 
 		storvsc_log_ratelimited(device, loglevel,
-			"tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x hv 0x%x\n",
+			"tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x host 0x%x\n",
 			scsi_cmd_to_rq(request->cmd)->tag,
 			stor_pkt->vm_srb.cdb[0],
 			vstor_packet->vm_srb.scsi_status,
-- 
2.43.0