linux-kernel - Re:[PATCH V2] usb: xhci: Add debugfs support for xHCI port bandwidth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250304125115.29332-1-raoxu@uniontech.com>
Date: Tue,  4 Mar 2025 20:51:15 +0800
From: raoxu <raoxu@...ontech.com>
To: mathias.nyman@...el.com,
	gregkh@...uxfoundation.org
Cc: linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	wangyuli@...ontech.com,
	zhanjun@...ontech.com,
	raoxu@...ontech.com
Subject: Re:[PATCH V2] usb: xhci: Add debugfs support for xHCI port bandwidth

On 2025/3/4 20:31, Mathias Nyman  wrote:

>I do however have some larger rework suggestions to this.
>
>Instead of queuing three commands on one file read, parsing and
>copy the content from each context dma into an array on stack, we could
>have separate files in debugfs for each speed, and queue one command
>for each. we could also skip the array on stack and print values from context
>directly.
>
>Something is also very off with the locks in this patch.
>Looks like every lock/unlock got replaced with an unlock

thanks Mathias Nyman,

Thank you for your valuable suggestions.I will separate files in debugfs for each speed.
skipping the array on stack and print values from context directly sounds good. looks is a error and i will fix it.
According to your suggestion i will send patch v3

thanks,

raoxu