linux-kernel - Re: Unwired pvrdma_modify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOuBmuZdG7SWWmmhtEF09B5A4O-s+_h_uZnmTOPyKtQJGM9=wA@mail.gmail.com>
Date: Tue, 4 Mar 2025 13:25:55 +0000
From: Bryan Tan <bryan-bt.tan@...adcom.com>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: Jason Gunthorpe <jgg@...pe.ca>, vishnu.dasa@...adcom.com, leon@...nel.org, 
	bcm-kernel-feedback-list@...adcom.com, linux-rdma@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: Unwired pvrdma_modify_device ?

On Mon, Mar 3, 2025 at 6:42 PM Dr. David Alan Gilbert <linux@...blig.org>
wrote:
> * Jason Gunthorpe (jgg@...pe.ca) wrote:
> > On Sun, Mar 02, 2025 at 10:05:11PM +0000, Dr. David Alan Gilbert wrote:
> > > Hi,
> > >   I noticed that pvrdma_modify_device() in
> > >    drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
> > > isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ?
> > >
> > > (I've not got VMWare anywhere to try it on, and don't know the innards
> > > of RDMA drivers; so can't really test it).
>
> Hi Jason,
>   Thanks for the reply,
>
> > Seems probably right
> >
> > But at this point I'd just delete it unless pvrdma maintainers say
> > otherwise in the next week
>
> OK, lets see if they wake up.
>
> Dave

Thanks David for bringing this up. You're right, it looks like we
never wired it up to pvrdma_dev_ops. Feel free to remove it.

Content of type "text/html" skipped

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5430 bytes)