linux-kernel - Re: [PATCH] iommufd: Fix uninitialized rc in iommufd_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250304134113.GJ133783@nvidia.com>
Date: Tue, 4 Mar 2025 09:41:13 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: kevin.tian@...el.com, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommufd: Fix uninitialized rc in iommufd_access_rw()

On Thu, Feb 27, 2025 at 12:07:29PM -0800, Nicolin Chen wrote:
> Reported by smatch:
> drivers/iommu/iommufd/device.c:1392 iommufd_access_rw() error: uninitialized symbol 'rc'.
> 
> Fixes: 8d40205f6093 ("iommufd: Add kAPI toward external drivers for kernel access")
> Cc: stable@...r.kernel.org
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <error27@...il.com>
> Closes: https://lore.kernel.org/r/202502271339.a2nWr9UA-lkp@intel.com/
> [nicolinc: can't find an original report but only in "old smatch warnings"]
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
> ---
>  drivers/iommu/iommufd/device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c
> index 6dccbf7217f5..b812ae40f382 100644
> --- a/drivers/iommu/iommufd/device.c
> +++ b/drivers/iommu/iommufd/device.c
> @@ -1348,7 +1348,7 @@ int iommufd_access_rw(struct iommufd_access *access, unsigned long iova,
>  	struct io_pagetable *iopt;
>  	struct iopt_area *area;
>  	unsigned long last_iova;
> -	int rc;
> +	int rc = 0;

This is a smatch error but it can't actually happen because:

  	if (!length)
  		return -EINVAL;

And:

	if (!iopt_area_contig_done(&iter))
		rc = -ENOENT;

Prevents an empty loop for iopt_for_each_contig_area()

And each loop does:

		rc = iopt_pages_rw_access(

Which will zero rc.

If for some reason rc was used uninitialized then it would be an error
so it should be rc = -EINVAL. I fixed it up.

Jason