linux-kernel - Re: [PATCH v3 17/20] ASoC: dt-bindings: tas2770: add flags for SDOUT pulldown and zero-fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250304135050.GA2485358-robh@kernel.org>
Date: Tue, 4 Mar 2025 07:50:50 -0600
From: Rob Herring <robh@...nel.org>
To: James Calligeros <jcalligeros99@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Shenghao Ding <shenghao-ding@...com>, Kevin Lu <kevin-lu@...com>,
	Baojun Xu <baojun.xu@...com>, Dan Murphy <dmurphy@...com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Shi Fu <shifu0704@...ndersoft.com>,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Alyssa Rosenzweig <alyssa@...enzweig.io>,
	Martin Povišer <povik+lin@...ebit.org>,
	Hector Martin <marcan@...can.st>, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	asahi@...ts.linux.dev, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v3 17/20] ASoC: dt-bindings: tas2770: add flags for SDOUT
 pulldown and zero-fill

On Thu, Feb 27, 2025 at 10:07:44PM +1000, James Calligeros wrote:
> TAS2770 can pull down and zero-fill SDOUT when not actively transmitting
> TDM slot data. Zero-fill is useful when there are no other amps on the
> bus. Pulldown is useful when the chip is attached to a shared bus.
> 
> Signed-off-by: James Calligeros <jcalligeros99@...il.com>
> ---
>  .../bindings/sound/ti,tas2770.yaml       | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2770.yaml b/Documentation/devicetree/bindings/sound/ti,tas2770.yaml
> index 8eab98a0f7a25a9c87d2c56fd0635ff8ecee17d0..3eba9bb34a581526f68b6bf2e8437e1f1e03d26f 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tas2770.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tas2770.yaml
> @@ -57,6 +57,18 @@ properties:
>        - 0 # Rising edge
>        - 1 # Falling edge
>  
> +  ti,sdout-pull-down:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      If present, SDOUT will be pulled low when not
> +      transmitting.
> +
> +  ti,sdout-zero-fill:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      If present, SDOUT will be zero-filled when not
> +      transmitting.

Can't you align this with the other property you added? Or extend the 
existing TDM properties we have.

Rob