linux-kernel - Re: [PATCH v12 2/2] mtd: rawnand: Add Loongson-1 NAND Controller Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a5a0299m.fsf@bootlin.com>
Date: Tue, 04 Mar 2025 14:52:21 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Keguang Zhang <keguang.zhang@...il.com>
Cc: Keguang Zhang via B4 Relay <devnull+keguang.zhang.gmail.com@...nel.org>,
  Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  Rob Herring <robh@...nel.org>,  Krzysztof Kozlowski
 <krzk+dt@...nel.org>,  Conor Dooley <conor+dt@...nel.org>,
  linux-mtd@...ts.infradead.org,  linux-kernel@...r.kernel.org,
  devicetree@...r.kernel.org,  linux-media@...r.kernel.org
Subject: Re: [PATCH v12 2/2] mtd: rawnand: Add Loongson-1 NAND Controller
 Driver

Hello Keguang,

>> > +static int ls1x_nand_exec_op(struct nand_chip *chip,
>> > +                          const struct nand_operation *op,
>> > +                          bool check_only)
>> > +{
>> > +     int ret;
>> > +
>>
>>         if (check_only) ?
>
> Sorry, I'm not sure if I understand correctly.
> nand_op_parser_exec_op() only checks patterns and will skip
> pattern->exec() when check_only = true. Therefore,
> ls1x_nand_check_op() should handle all opcode checks in that case, and
> leave check_only = false to nand_op_parser_exec_op().
> Then the code will return to:
>
> if (check_only)
>         return ls1x_nand_check_op(chip, op);
>
> return nand_op_parser_exec_op(chip, &ls1x_nand_op_parser, op, check_only);
>
> Am I right?

Absolutely, yes.

Thanks,
Miquèl