linux-kernel - Re: [PATCH v2 5/5] ASoC: wm8904: add DMIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8cGgcq4ynfeCNKp@opensource.cirrus.com>
Date: Tue, 4 Mar 2025 13:56:17 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Francesco Dolcini <francesco@...cini.it>
CC: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Saravana Kannan <saravanak@...gle.com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        <patches@...nsource.cirrus.com>,
        Ernest Van Hoecke
	<ernest.vanhoecke@...adex.com>,
        <linux-sound@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        "Francesco
 Dolcini" <francesco.dolcini@...adex.com>
Subject: Re: [PATCH v2 5/5] ASoC: wm8904: add DMIC support

On Mon, Feb 24, 2025 at 04:55:00PM +0100, Francesco Dolcini wrote:
> From: Ernest Van Hoecke <ernest.vanhoecke@...adex.com>
> 
> The WM8904 codec supports both ADC and DMIC inputs.
> 
> Get input pin functionality from the platform data and add the necessary
> controls depending on the possible additional routing.
> 
> The ADC and DMIC share the IN1L/DMICDAT1 and IN1R/DMICDAT2 pins.
> 
> This leads to a few scenarios requiring different DAPM routing:
> - When both are connected to an analog input, only the ADC is used.
> - When one line is a DMIC and the other an analog input, the DMIC source
>   is set from the platform data and a mux is added to select whether to
>   use the ADC or DMIC.
> - When both are connected to a DMIC, another mux is added to this to
>   select the DMIC source. Note that we still need to be able to select
>   the ADC system for use with the IN2L, IN2R, IN3L and IN3R pins.
> 
> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@...adex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> ---

Apologies for the delay, I think this looks good to me:

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles