linux-kernel - Re: [PATCH 1/8] media: dt-bindings: Document SC8280XP/SM8350 Venus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f7fea59-310d-4a7e-94f7-2483363012ba@kernel.org>
Date: Tue, 4 Mar 2025 15:00:37 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Stanimir Varbanov <stanimir.k.varbanov@...il.com>,
 Vikash Garodia <quic_vgarodia@...cinc.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Johan Hovold <johan+linaro@...nel.org>
Subject: Re: [PATCH 1/8] media: dt-bindings: Document SC8280XP/SM8350 Venus

On 04/03/2025 14:07, Bryan O'Donoghue wrote:
> From: Konrad Dybcio <konradybcio@...nel.org>
> 
> Both of these SoCs implement an IRIS2 block, with SC8280XP being able
> to clock it a bit higher.
> 
> Document it.
> 
> Signed-off-by: Konrad Dybcio <konradybcio@...nel.org>
> Link: https://lore.kernel.org/r/20230731-topic-8280_venus-v1-1-8c8bbe1983a5@linaro.org
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> [ bod: dropped dts video-encoder/video-decoder ]
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---


If this is the same version, then please implement previous feedback.

If this is a new version, then please mark it as v2 and provide
changelog. This is what b4 gave me:

b4 diff
'<20250304-b4-linux-media-comitters-sc8280xp-venus-v1-1-279c7ea55493@...aro.org>'
Grabbing thread from
lore.kernel.org/all/20250304-b4-linux-media-comitters-sc8280xp-venus-v1-1-279c7ea55493@...aro.org/t.mbox.gz
Breaking thread to remove parents of
20250304-b4-linux-media-comitters-sc8280xp-venus-v1-0-279c7ea55493@...aro.org
---
Analyzing 9 messages in the thread
Could not find lower series to compare against.

...

> +
> +        operating-points-v2 = <&venus_opp_table>;
> +        iommus = <&apps_smmu 0x2100 0x400>;
> +        memory-region = <&pil_video_mem>;
> +
> +        status = "disabled";

So it is the same...

Same comments apply, same review.

Best regards,
Krzysztof