linux-kernel - Re: [PATCH v3 1/6] dt-bindings: pinctrl: Add bindings for BCM21664 pin controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174109694544.2517876.17977367715126492989.robh@kernel.org>
Date: Tue, 4 Mar 2025 08:02:25 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Artur Weber <aweber.kernel@...il.com>
Cc: devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
	Stanislav Jakubek <stano.jakubek@...il.com>,
	Conor Dooley <conor+dt@...nel.org>, Ray Jui <rjui@...adcom.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	~postmarketos/upstreaming@...ts.sr.ht,
	linux-arm-kernel@...ts.infradead.org,
	Scott Branden <sbranden@...adcom.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/6] dt-bindings: pinctrl: Add bindings for BCM21664
 pin controller


On Mon, 03 Mar 2025 21:54:46 +0100, Artur Weber wrote:
> Add device tree bindings for the pin controller included in the
> BCM21664 chip. The bindings are based off brcm,bcm11351-pinctrl.yaml;
> both chips use the same driver, but have different pins, and the
> BCM21664 has 6 alt modes instead of 4.
> 
> Signed-off-by: Artur Weber <aweber.kernel@...il.com>
> ---
> Changes in v3:
> - Fix example for I2C pins
> - Specify bias-pull-up/bias-pull-down as a boolean
> - Add gpio16/gpio17 to list of I2C pins in slew-rate description
> - Use additionalProperties: false on pin group and specify valid
>   properties for more strict checking
> 
> Changes in v2:
> - Drop "property: true" declarations which had no effect with
>   "unevaluatedProperties: false"
> - Define property limits for I2C pins only instead of standard pins,
>   making the pin-specific "if" condition significantly smaller
> ---
>  .../bindings/pinctrl/brcm,bcm21664-pinctrl.yaml    | 152 +++++++++++++++++++++
>  1 file changed, 152 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>