linux-kernel - Re: [patch V2 08/17] posix-timers: Rework timer removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878qpk7uva.ffs@tglx>
Date: Tue, 04 Mar 2025 15:06:49 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Pavel Tikhomirov <ptikhomirov@...tuozzo.com>, LKML
 <linux-kernel@...r.kernel.org>
Cc: Anna-Maria Behnsen <anna-maria@...utronix.de>, Frederic Weisbecker
 <frederic@...nel.org>, Benjamin Segall <bsegall@...gle.com>, Eric Dumazet
 <edumazet@...gle.com>, Andrey Vagin <avagin@...nvz.org>, Peter Zijlstra
 <peterz@...radead.org>
Subject: Re: [patch V2 08/17] posix-timers: Rework timer removal

On Tue, Mar 04 2025 at 18:20, Pavel Tikhomirov wrote:
> On 3/4/25 18:10, Pavel Tikhomirov wrote:
>>> +    while (timer->kclock->timer_del(timer) == TIMER_RETRY) {
>>> +        guard(rcu)();
>>> +        spin_unlock_irq(&timer->it_lock);
>> 
>> Maybe "guard(spinlock_irq)(&timer->it_lock);", since we already use 
>> guard constructions everywhere else?
>
> Sorry I'm just stupid. Please ignore.

You're not the first one to trip over this :)