linux-kernel - Re: [PATCH] staging: iio: adis16203: Remove unneeded spi_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250304143230.6d91f64d@jic23-huawei>
Date: Tue, 4 Mar 2025 14:32:30 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Saalim Quadri <danascape@...il.com>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com,
 gregkh@...uxfoundation.org, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: iio: adis16203: Remove unneeded
 spi_set_drvdata()

On Mon,  3 Mar 2025 23:35:23 +0530
Saalim Quadri <danascape@...il.com> wrote:

> * Since we are making use of devm_iio_device_register(), we no longer
>   need this nor do we have any spi_get_drvdata() in the driver.
> 
Why have a single bullet point?  
Also please rewrite in imperative sense. Something like

Driver no longer has a remove callback after conversion to fully
devm_ managed probe().  Remove now unneeded spi_get_drvdata()
as that value was previously on read in the remove() callback.

> Signed-off-by: Saalim Quadri <danascape@...il.com>
Code is fine, so just this patch description stuff.

Thanks,

Jonathan

> ---
>  drivers/staging/iio/accel/adis16203.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
> index c1c73308800c..3faf3c61046a 100644
> --- a/drivers/staging/iio/accel/adis16203.c
> +++ b/drivers/staging/iio/accel/adis16203.c
> @@ -267,8 +267,6 @@ static int adis16203_probe(struct spi_device *spi)
>  	if (!indio_dev)
>  		return -ENOMEM;
>  	st = iio_priv(indio_dev);
> -	/* this is only used for removal purposes */
> -	spi_set_drvdata(spi, indio_dev);
>  
>  	indio_dev->name = spi->dev.driver->name;
>  	indio_dev->channels = adis16203_channels;