linux-kernel - RE: [PATCH 1/5] io_uring/rsrc: split out io_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18e5b97243724652998257c52be8cc49@huawei.com>
Date: Mon, 3 Mar 2025 07:20:50 +0000
From: lizetao <lizetao1@...wei.com>
To: Caleb Sander Mateos <csander@...estorage.com>
CC: "io-uring@...r.kernel.org" <io-uring@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Jens Axboe
	<axboe@...nel.dk>, Pavel Begunkov <asml.silence@...il.com>
Subject: RE: [PATCH 1/5] io_uring/rsrc: split out io_free_node() helper

Hi,

> -----Original Message-----
> From: Caleb Sander Mateos <csander@...estorage.com>
> Sent: Saturday, March 1, 2025 7:59 AM
> To: Jens Axboe <axboe@...nel.dk>; Pavel Begunkov <asml.silence@...il.com>
> Cc: Caleb Sander Mateos <csander@...estorage.com>; io-
> uring@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH 1/5] io_uring/rsrc: split out io_free_node() helper
> 
> Split the freeing of the io_rsrc_node from io_free_rsrc_node(), for use with
> nodes that haven't been fully initialized.
> 
> Signed-off-by: Caleb Sander Mateos <csander@...estorage.com>
> ---
>  io_uring/rsrc.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c index 45bfb37bca1e..d941256f0d8c
> 100644
> --- a/io_uring/rsrc.c
> +++ b/io_uring/rsrc.c
> @@ -485,10 +485,16 @@ int io_files_update(struct io_kiocb *req, unsigned int
> issue_flags)
>  		req_set_fail(req);
>  	io_req_set_res(req, ret, 0);
>  	return IOU_OK;
>  }
> 
> +static void io_free_node(struct io_ring_ctx *ctx, struct io_rsrc_node
> +*node) {

Would it be better to take a io_alloc_cache as parameter and put it into alloc_cache.h 
as a general function, so other modules can use it too, just like io_uring/futex.

> +	if (!io_alloc_cache_put(&ctx->node_cache, node))
> +		kvfree(node);
> +}
> +
>  void io_free_rsrc_node(struct io_ring_ctx *ctx, struct io_rsrc_node *node)  {
>  	if (node->tag)
>  		io_post_aux_cqe(ctx, node->tag, 0, 0);
> 
> @@ -504,12 +510,11 @@ void io_free_rsrc_node(struct io_ring_ctx *ctx,
> struct io_rsrc_node *node)
>  	default:
>  		WARN_ON_ONCE(1);
>  		break;
>  	}
> 
> -	if (!io_alloc_cache_put(&ctx->node_cache, node))
> -		kvfree(node);
> +	io_free_node(ctx, node);
>  }
> 
>  int io_sqe_files_unregister(struct io_ring_ctx *ctx)  {
>  	if (!ctx->file_table.data.nr)
> --
> 2.45.2
> 

---
Li Zetao