linux-kernel - Re: [PATCH next] iio: adc: ad4030: fix error pointer dereference in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250304145309.066aeaae@jic23-huawei>
Date: Tue, 4 Mar 2025 14:53:09 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Nuno Sá <noname.nuno@...il.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, Esteban Blanc 
 <eblanc@...libre.com>, Michael Hennerich <michael.hennerich@...log.com>,
 Nuno Sá	 <nuno.sa@...log.com>, Lars-Peter Clausen
 <lars@...afoo.de>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] iio: adc: ad4030: fix error pointer dereference in
 probe()

On Fri, 28 Feb 2025 13:22:37 +0000
Nuno Sá <noname.nuno@...il.com> wrote:

> On Fri, 2025-02-28 at 12:35 +0300, Dan Carpenter wrote:
> > The intention here was obviously to return an error if devm_regmap_init()
> > fails, but the return statement was accidentally left out.  This leads to
> > an error pointer dereference when we call:
> > 
> > 	ret = ad4030_detect_chip_info(st);
> > 
> > Add the return statement.
> > 
> > Fixes: ec25cf6f1ee3 ("iio: adc: ad4030: add support for ad4632-16 and ad4632-
> > 24")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> > ---  
> 
> Reviewed-by: Nuno Sá <nuno.sa@...log.com>
Applied.